fix(iac): scan the workspace when no path is configured - #169
Merged
tembleking merged 1 commit intoAug 5, 2026
Merged
Conversation
tembleking
requested review from
Jujuyeh,
airadier,
alecron and
mateobur
as code owners
August 4, 2026 10:06
mateobur
approved these changes
Aug 4, 2026
The step hands its configured path straight to the scanner, and that path starts out empty, so the scanner was invoked with an empty argument instead of falling back to the current directory — and the current directory was never set either, so it was whatever directory the agent's JVM happened to sit in. A default-configured step therefore walked something that has nothing to do with the build, which is also not what the README documents; verified from a real build's console: `Scanning paths paths=[""]` with no working directory in the launched command. Blank paths are now dropped before the fallback, and the process runs in the workspace, so both the default and any relative path mean what they say. The report also names the workspace when no path is configured, since that is the root its module paths are relative to.
tembleking
force-pushed
the
fix/iac-default-path-scans-the-workspace
branch
from
August 5, 2026 08:09
4559808 to
c2b6e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #168.
A step with no
pathconfigured was not scanning the workspace, which is what the README documents and theonly thing that makes sense for a build. Two things went wrong at once, both visible in a real build's console:
The step passes its configured path through as is, and an empty string is still an argument, so the
.fallback never applied and the scanner got an empty path. And nothing ever set the process working directory,
so the "current directory" that the empty path (or any relative path, such as the documented
path: 'infrastructure/') resolved against was wherever the agent's JVM happened to be started — for an inboundagent, its own installation directory.
Blank paths are now dropped before the fallback and the scanner runs in the workspace, so
.and relative pathsmean the workspace. The report page also names the workspace as the scan root in that case, since that is what
the module paths in it are relative to; with a path configured nothing changes.
Anyone who had worked around this by pointing
pathat an absolute directory keeps working — absolute paths areunaffected. Anyone relying on the old (accidental) behaviour of scanning the agent's own directory will now scan
the workspace instead.