chore: bump sysdig-cli-scanner to 1.28.0, oldest tested to 1.22.6 - #171
Merged
tembleking merged 1 commit intoAug 5, 2026
Merged
Conversation
tembleking
requested review from
Jujuyeh,
airadier,
alecron and
mateobur
as code owners
August 4, 2026 10:43
mateobur
approved these changes
Aug 4, 2026
Keeps the pinned default and the oldest still-maintained version inside the supported window, with the recorded scan-result fixtures regenerated against both so report parsing is exercised on what those versions actually emit. The pinned-version test in ScannerBinaryProviderTest carried the version as a bare literal with no marker, so `just update-cli-scanner` left it behind: the Mockito stub stopped matching, the download returned null and the failure surfaced as an unrelated NPE. It now reads the version off a marked constant, and the os/arch URL tests share one deliberately unmarked constant so they cannot drift apart. Parent POM, plugin BOM and flake.lock are refreshed in passing.
tembleking
force-pushed
the
chore/bump-cli-scanner-1.28.0
branch
from
August 5, 2026 08:09
dd8a405 to
8f41553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #169.
Keeps the pinned default and the oldest still-maintained version inside the supported window, with the
recorded scan-result fixtures regenerated against both so report parsing is exercised on what those
versions actually emit.
The pinned-version test in
ScannerBinaryProviderTestcarried the version as a bare literal with nomarker, so
just update-cli-scannerleft it behind: the Mockito stub stopped matching, the downloadreturned null and the failure surfaced as an unrelated NPE. It now reads the version off a marked
constant, and the os/arch URL tests share one deliberately unmarked constant so they cannot drift apart.
Parent POM, plugin BOM and flake.lock are refreshed in passing.