Repository navigation
Conversation
Removes .node-version (only Cloudflare Pages read it; the workflows already float on node-version: 22) and relaxes the engines floor from >=22.22.3 to >=22.22.0, the minimum Astro 7.4 actually requires.
Deploying specification-website with
|
| Latest commit: |
4d15fc2
|
| Status: | 🚫 Build failed. |
Owner
Author
|
Superseded by #274. Unpinning is impossible on Pages (the build ignores NODE_VERSION from project settings and falls back to the image default 22.16.0, which Astro 7.4 refuses), so the .node-version pin stays and is raised to 22.23.4 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joost: "Node hoeft niet gepind."
.node-version(22.22.3). Only Cloudflare Pages read it; all GitHub workflows already float onnode-version: 22.enginesfloor in package.json + lockfile:>=22.22.3→>=22.22.0, the minimum Astro 7.4 actually requires (not the old pre-Astro-7.4 floor of 22.12, which would understate it).This reverts the pin half of #265's
fix(build)commit while keeping the Astro/mdx bump itself.