Skip to content

fix(clipboard): avoid NullPointerException in read() on Android when the clip or its description is null #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qliqdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(clipboard): avoid NullPointerException in read() on Android when the clip or its description is null #2612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions clipboard/android/src/main/java/com/capacitorjs/plugins/clipboard/Clipboard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,19 @@ public ClipboardData read() {
if (clipboard != null) {
CharSequence value = null;

if (clipboard.hasPrimaryClip()) {
if (clipboard.getPrimaryClipDescription().hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
// hasPrimaryClip() can be true while getPrimaryClip() and
// getPrimaryClipDescription() still return null, e.g. while the app
// is not focused yet, so read the clip once and check it.
ClipData clip = clipboard.getPrimaryClip();
if (clip != null && clip.getItemCount() > 0) {
ClipDescription description = clip.getDescription();
ClipData.Item item = clip.getItemAt(0);
if (description != null && description.hasMimeType(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
Logger.debug(TAG, "Got plaintxt");
ClipData.Item item = clipboard.getPrimaryClip().getItemAt(0);
value = item.getText();
} else {
Logger.debug(TAG, "Not plaintext!");
ClipData.Item item = clipboard.getPrimaryClip().getItemAt(0);
value = item.coerceToText(context).toString();
value = item.coerceToText(context);
}
}

Expand Down