Repository navigation
Conversation
…the clip or its description is null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android,
Clipboard.read()can crash the whole app:hasPrimaryClip()can returntruewhilegetPrimaryClipDescription()/getPrimaryClip()still returnnull(for example right after launch, before the activity has window focus, when Android 10+ restricts clipboard access). The exception is thrown on the plugin thread, so it cannot be caught from JS and the app is killed. In production we saw it on 14 of 29 Android users of one app (Android 11, OnePlus 8 Pro among others), with@capacitor/clipboard8.0.1.The fix reads the primary clip once and checks the clip, its item count and its description before using them. When nothing can be read,
read()rejects with the existing "There is no data on the clipboard" error instead of crashing.Change Type
Platforms Affected
Tests or Reproductions
./gradlew build testinclipboard/androidandprettier --checkpass.