chore(deps): group the codeql-action pins so both halves move together - #13
Conversation
5731c6a to
b6a5729
Compare
7d52116 to
4b327eb
Compare
b6a5729 to
1a871da
Compare
Dependabot opened two pull requests this morning and neither can pass:
#5 (codeql-action/init) Loaded a configuration file for version '4.37.9',
but running version '4.36.2'
#6 (codeql-action/analyze) Loaded a configuration file for version '4.36.2',
but running version '4.37.9'
`github/codeql-action/init` and `github/codeql-action/analyze` are two entry points
into one action, and the bundle checks at runtime that both halves came from the same
release. Ungrouped, dependabot treats each path as its own dependency and opens a
pull request per path, so each one bumps half the pair and leaves the workflow
internally inconsistent. The failure is not a regression in either version and not
something either pull request can fix on its own.
Grouping makes the pin move as the unit it already is. This is also the only
dependency in the repository where that applies: everything else in
`.github/workflows` is a standalone action whose version is nobody else's business.
#5 and #6 have to be closed for the grouped pull request to replace them — dependabot
will not fold existing single-dependency pull requests into a new group.
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
A group covers version updates only unless it says otherwise — `applies-to`
defaults to `version-updates` — so the grouping added here left one way for the
pin to split again: a security advisory on `codeql-action/init` or
`codeql-action/analyze` arrives as its own single-dependency pull request,
bumps half the pair, and reproduces the failure this file is meant to prevent:
Loaded a configuration file for version '4.37.9', but running version '4.36.2'
Stating the pattern twice, once per `applies-to`, closes that path. The first
group now says `version-updates` explicitly rather than relying on the default,
because the two entries only read as a pair if both name their scope.
Validated against the SchemaStore `dependabot-2.0` schema; nothing in CI checks
this file, so a malformed one would surface only as a repository-level
Dependabot error days later.
Signed-off-by: Rybkin <alexander.rybkin@intel.com>
1a871da to
889d349
Compare
|
Reviewed, rebased onto The diagnosis holds, measured rather than taken on trust. Both halves' failures, from the two jobs: And the dependency names dependabot actually uses, from its own commit trailers, are What the extra commit fixes. Checks. Nothing in CI validates this file — a malformed one surfaces only as a repository-level Dependabot error days later — so: YAML parses, and the result validates against the SchemaStore One interaction worth recording. Alternatives considered and rejected: grouping everything ( Follow-up, not for this pull request. #5 and #6 both propose the same SHA |
xaleryb
left a comment
There was a problem hiding this comment.
Approved. Rebased onto 2c8c60a, extended by one commit closing the applies-to gap, and verified — details in the review comment above. GitHub's own .github/dependabot.yml check passes alongside the rest.
Per the discussion, #5 and #6 will be merged rather than closed, so Dependabot records 4.37.9 as applied rather than dismissed. Both propose the same SHA cdf488f5, and codeql.yml's concurrency group cancels a superseded run on main, so the intermediate split state need never report.
5 of 5 in a split stack.
mainmain#9 and #12 are independent and both go straight to
main— they fix the two unrelated jobsthat are red there, and neither waits on the other. #10, #11 and #13 sit on #9 only so their
Validate runs are green while
main's link check is failing; GitHub retargets them tomainwhen #9 lands.
mainis failing two independent jobs, so any PR fixing one still displays the other.Nothing here introduces the failure it shows:
zizmor— the Pages workflow from #7validate— the dead docs.vllm.ai linkEverything else is green on every PR. All five test-merge into
maincleanly in any order,and the merged combination passes the full gate plus zizmor and actionlint.
What this changes
Dependabot opened two pull requests this morning and neither can pass:
github/codeql-action/initandgithub/codeql-action/analyzeare two entry points into oneaction, and the bundle checks at runtime that both halves came from the same release.
Ungrouped, dependabot treats each path as its own dependency and opens a pull request per
path — so each one bumps half the pair and leaves the workflow internally inconsistent. The
failure is not a regression in either version, and not something either pull request can fix
on its own.
Grouping makes the pin move as the unit it already is. It is also the only dependency here
where that applies: everything else in
.github/workflowsis a standalone action whoseversion is nobody else's business.
Needs a maintainer action
#5 and #6 have to be closed for the grouped pull request to replace them — dependabot
will not fold existing single-dependency pull requests into a new group. I have not touched
them.
Checklist
descriptionagainst requests a user would really type — see CONTRIBUTING.md. (no skill text changed)python3 tools/validate_skills.pypasses locally.git commit -s(DCO).