Skip to content

fix(ci): run the pinned-upstream check even when the link check failed - #11

Merged
xaleryb merged 1 commit into
mainfrom
fix/sync-check-runs-when-link-check-fails
Sep 4, 2026
Merged

fix(ci): run the pinned-upstream check even when the link check failed#11
xaleryb merged 1 commit into
mainfrom
fix/sync-check-runs-when-link-check-fails

Conversation

@napetrov

@napetrov napetrov commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

4 of 5 in a split stack.

# PR scope base
1 #9 a dead link in an imported body warns instead of failing — unblocks Validate main
2 #12 scope the Pages token to the deploy job and pin its actions — unblocks Security main
3 #10 retry a 429 in the link check instead of accepting it #9
4 #11 run the pinned-upstream check even when the link check failed #9
5 #13 group the codeql-action pins so both halves move together #9

#9 and #12 are independent and both go straight to main — they fix the two unrelated jobs
that are red there, and neither waits on the other. #10, #11 and #13 sit on #9 only so their
Validate runs are green while main's link check is failing; GitHub retargets them to main
when #9 lands.

main is failing two independent jobs, so any PR fixing one still displays the other.
Nothing here introduces the failure it shows:

PR red check fixed by
#9, #10, #11, #13 zizmor — the Pages workflow from #7 #12
#12 validate — the dead docs.vllm.ai link #9

Everything else is green on every PR. All five test-merge into main cleanly in any order,
and the merged combination passes the full gate plus zizmor and actionlint.

What this changes

Imported skills match their pinned upstream is the step after Link check and has no
if: always(), so it has never run on a commit where a link was dead. main has been
red on the link check since this morning, and for that entire window the answer to "does
what this repository publishes still match what was reviewed?" was not yes — it was
unknown, because nothing asked.

The two checks are independent. One reads URLs inside skill bodies. The other re-fetches
each pinned commit and byte-compares the vendored copy against it — and it is the more
serious of the pair, because a mismatch means either the copy was edited here or upstream
moved the commit under the pin, and both mean this repository is publishing something
nobody reviewed. Letting the first decide whether the second runs puts that answer in the
hands of whoever last reorganised a documentation site.

It does run now, and it passes — every import matches its pin:

OK   skills/vllm-xpu-run/ 6 file(s)
OK   skills/xpu-system-setup/ 4 file(s)
...

Step ordering is left alone. Link check first is the cheaper and more commonly
interesting failure, and with if: always() the order no longer decides what gets
reported.

Checklist

  • I checked description against requests a user would really type — see CONTRIBUTING.md. (no skill text changed)
  • python3 tools/validate_skills.py passes locally.
  • Every commit is signed off with git commit -s (DCO).

@napetrov
napetrov requested a review from xaleryb as a code owner September 3, 2026 16:04
@napetrov
napetrov force-pushed the fix/sync-check-runs-when-link-check-fails branch from 268fb75 to fec8b20 Compare September 3, 2026 16:07
@napetrov
napetrov changed the base branch from fix/imported-body-dead-link-warns to fix/pages-workflow-permissions-and-pins September 3, 2026 16:07
@napetrov
napetrov force-pushed the fix/pages-workflow-permissions-and-pins branch from 7d52116 to 4b327eb Compare September 3, 2026 16:27
@napetrov
napetrov force-pushed the fix/sync-check-runs-when-link-check-fails branch from fec8b20 to 77bd4b2 Compare September 3, 2026 16:27
@napetrov
napetrov changed the base branch from fix/pages-workflow-permissions-and-pins to fix/imported-body-dead-link-warns September 3, 2026 16:27
@napetrov napetrov closed this Sep 3, 2026
@napetrov napetrov reopened this Sep 3, 2026
`Imported skills match their pinned upstream` is the step after `Link check` and had
no `if: always()`, so it has never run on a commit where a link was dead. `main` has
been red on the link check since this morning, and for that whole window the answer
to "does what this repository publishes still match what was reviewed?" was not
"yes" — it was unknown, because nothing asked.

The two checks are independent. One reads URLs inside skill bodies; the other
re-fetches each pinned commit and byte-compares the vendored copy against it. The
second is the more serious of the pair — a mismatch means either the copy was edited
here or upstream moved the commit under the pin, and both mean this repository is
publishing something nobody reviewed. Letting the first decide whether the second
runs puts that answer in the hands of whoever last reorganised a documentation site.

It does run now, and it passes: every import matches its pin.

Ordering is left as it is. `Link check` first is the cheaper and more commonly
interesting failure, and with `if: always()` the order no longer decides what gets
reported.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@xaleryb
xaleryb changed the base branch from fix/imported-body-dead-link-warns to main September 4, 2026 01:11
@xaleryb
xaleryb force-pushed the fix/sync-check-runs-when-link-check-fails branch 2 times, most recently from 77bd4b2 to c33fbb6 Compare September 4, 2026 01:11
@xaleryb
xaleryb merged commit bf7da77 into main Sep 4, 2026
9 of 15 checks passed
@xaleryb
xaleryb deleted the fix/sync-check-runs-when-link-check-fails branch September 4, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants