Skip to content

ci: run the test matrix and package-smoke only after static passes #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
napetrov wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

ci: run the test matrix and package-smoke only after static passes #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,14 @@ jobs:
if: ${{ !cancelled() }}
run: deptry .

# The pool jobs that cost the most (the test matrix, package-smoke) wait for
# `static`: a PR that fails lint stops there instead of taking six more
# runners. The cost is the wall time of `static` plus one more pool boot on a
# green run. typecheck, one job, still runs alongside `static`; windows-smoke,
# on windows-latest, does not wait, so no chain spans both queues.
test:
name: Tests (py${{ matrix.python-version }})
needs: static
runs-on: ${{ github.repository_owner == 'intel' && 'intel-ubuntu-latest' || 'ubuntu-latest' }}
permissions:
contents: read
Expand Down Expand Up @@ -268,6 +274,7 @@ jobs:
# the lock: the floor version checks what `pip install dokimi` gives a 3.11 user.
package-smoke:
name: Package install smoke test (py${{ matrix.python-version }})
needs: static
runs-on: ${{ github.repository_owner == 'intel' && 'intel-ubuntu-latest' || 'ubuntu-latest' }}
strategy:
fail-fast: false
Expand Down
Loading