Skip to content

ci: run the test matrix and package-smoke only after static passes - #208

Open
napetrov wants to merge 1 commit into
intel:mainfrom
napetrov:ci/needs-static
Open

napetrov wants to merge 1 commit into
intel:mainfrom
napetrov:ci/needs-static

Conversation

@napetrov

Copy link
Copy Markdown
Contributor

Summary

 ci.yml (pull_request, push, schedule)
   static            # ruff, schema, zizmor, pre-commit, bandit: seconds
   typecheck         # parallel, unchanged
+  test ×4           needs: static
+  package-smoke ×2  needs: static
   windows-smoke     # windows-latest, stays ungated: no chain spans both queues

A PR that fails static no longer takes six more pool runners for the test matrix and package-smoke. That cuts CI cost during review sweeps, when many red pushes land at once.

Evidence

  • Before: a lint failure still started 4 test legs and 2 package-smoke legs. Each one waits about 4 min for a pool boot and then runs the whole job.
  • After: those 6 jobs show as skipped when static fails. On a green run they start after static finishes.
  • pytest tests/test_ci_local.py: 27 passed. This PR's own run shows the new ordering.

Merge Danger

Door: two-way

Revert drops three lines (two needs: and one comment block).

Blast Radius: latency

A green PR now finishes later by the wall time of static plus one pool boot (about 4 min median). Required checks: when static fails, the skipped jobs don't block the merge by themselves, but the failing static check does.

🤖 Generated with Claude Code

@napetrov napetrov added the skip-changelog No user-visible change: bypasses the changelog fragment check label Oct 23, 2026
A PR that fails lint stopped at static still took six pool runners for
the test matrix and package-smoke. windows-smoke stays ungated so no
needs: chain spans the pool and windows-latest queues.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (be15dd9) to head (212b3b5).
⚠️ Report is 3 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   91.98%   92.01%   +0.03%     
==========================================
  Files         223      223              
  Lines       27743    27768      +25     
  Branches     4560     4563       +3     
==========================================
+ Hits        25520    25552      +32     
+ Misses       1574     1570       -4     
+ Partials      649      646       -3     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-visible change: bypasses the changelog fragment check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants