Repository navigation
ci: run less on each PR push: trim matrices, filter paths, fold one workflow - #207
Merged
Merged
Conversation
napetrov
requested review from
antonwolfy,
jharlow-intel,
vchamarthi and
xaleryb
as code owners
October 23, 2026 23:12
…orkflow - ci.yml: PRs run the test matrix ends only (3.11, 3.14 coverage leg) and package-smoke on 3.11; 3.12/3.13 still run on main, weekly and dispatch. Conditional `exclude:` entries, so ci_local.py still reads the full lists. Only the coverage leg fetches full history. - codeql.yml: PR runs only when Python or workflow files change. - docs.yml: PR skips changes limited to tests, changelog fragments, other workflows. - cli-interface.yml: PR runs only when the CLI's sources, the dump script or the lock change. - docs-review-triggers folded into the changelog job: one runner wait per push instead of two. No status check is required on main, so a filtered-out workflow blocks no merge. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 223 223
Lines 27743 27743
Branches 4560 4560
==========================================
- Hits 25520 25518 -2
- Misses 1574 1575 +1
- Partials 649 650 +1 🚀 New features to boost your workflow:
|
xaleryb
approved these changes
Oct 25, 2026
xaleryb
left a comment
Contributor
There was a problem hiding this comment.
Ran the full suite and ruff on Linux at 45800e2: 7744 passed, clean. Merges cleanly with #208. Checked that no page built into the site links into tests/ or .github/, so the docs filter skips nothing the strict build reads.
cli-interface.yml, lines 15-18: forpull_request,pathsis matched against the PR's diff with its base as it is now. A PR that changesdokimi/cli.py, getscli-interface-change, and then reverts that file no longer matches, so the workflow does not run and the label and comment stay. Either say so in the comment (the label is then removed by hand), or drop the filter for this workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fewer CI jobs on each PR push. Test coverage on main is unchanged.
The matrix cut uses conditional
exclude:entries ('3.12'on a PR,'none'otherwise), not a computed list:scripts/ci_local.pyreadspython-versionas a list.The path filters are workflow-level. No status check is required on main (rulesets: deletion, non-FF, PR, Copilot review only), so a filtered-out workflow blocks no merge.
Not included:
ci.ymlon docs-only PRs: ~100 test files read.mdfiles, andtwine check --strictrenders the README, so a docs-only change can still fail CI.Evidence
scripts/ci_local.py:ci_pythons()still returns('3.13', ['3.11','3.12','3.13','3.14']), andrun --offline --jobs fragmentruns both steps, fragment and docs pages: 2 passed.zizmor --offline --min-severity medium .github/workflows: no findings.7742 passed, 23 skipped. pre-commit (CI's SKIP set): pass.Merge Danger
Door: two-way
Revert the commit to restore the old triggers.
Blast Radius: CI-only
docs-review-triggerscheck name no longer exists; it is now a step of thechangelogcheck.🤖 Generated with Claude Code