feat: enforce configurable max image size and improve column management flow - #1195
Merged
Merged
Conversation
…nt flow Complete the per-column max image size feature (cap it at 20MB, enforce it during auto-import validation via HEAD-request size checks, update widget copy), and improve the column add/edit/manage flow: - Extract a reusable GatedField component for plan-gated fields - Auto-sync the Key field from Name with visible feedback, plus client-side duplicate-key validation - Confirm before a column type change would drop existing validations - Unify column creation into a single modal-based flow instead of two divergent code paths - Fix JSON-editor error parsing (index/message extraction broke past 10 columns; a typo caused later errors to overwrite earlier ones) - Fix a bulk-update error notification that rendered blank - Add a drag-and-drop target highlight to the columns table Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hqy3rtwmRHKRsqKY5ntuT9
|
View your CI Pipeline Execution ↗ for commit 291421c
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
2 tasks
chavda-bhavik
added a commit
that referenced
this pull request
Sep 1, 2026
## Summary - Follow-up to #1195: extracting the `GatedField` component dropped the `colors` import in `ColumnForm.tsx` and left a stray light-gray placeholder (`#f8f9fa`) as the "Column Validations" panel's background instead of the app's dark `colors.BGSecondaryDark` (`#1D1E22`), which clashed visibly with the rest of the (dark-themed) modal. - Restores the correct background. ## Test plan - [x] `apps/web` type-checks cleanly (`tsc --noEmit`) - [ ] Open the column add/edit modal on quality and confirm the right-hand "Column Validations" panel matches the app's dark theme Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> https://claude.ai/code/session_01Hqy3rtwmRHKRsqKY5ntuT9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GatedFieldcomponent, replacing ~8 copy-pasted plan-gating (lock/badge/upsell) blocksBugs fixed along the way
useColumnsEditor.tsx) mis-attributed/mis-trimmed validation errors for templates with 10+ columns (character-index parsing instead of proper index extraction), and a typo (Array.isArray[...]instead ofArray.isArray(...)) caused a second error on the same column to silently overwrite the first instead of appending.useUpdateBulkColumns.ts) rendered a blank notification toast (notify(error.message + 'Hola')passed a raw string as the notification key, which doesn't exist, so nothing displayed) — now shows the actual error.Test plan
apps/webtype-checks cleanly (tsc --noEmit)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01Hqy3rtwmRHKRsqKY5ntuT9