fix: restore dark theme background on column validations panel - #1196
Merged
Merged
Conversation
The GatedField extraction dropped the colors import and left a placeholder light-gray fallback on the Column Validations panel, which clashed with the app's dark UI instead of using the same BGSecondaryDark shade as the rest of the modal. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hqy3rtwmRHKRsqKY5ntuT9
|
View your CI Pipeline Execution ↗ for commit c2e1fcb
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GatedFieldcomponent dropped thecolorsimport inColumnForm.tsxand left a stray light-gray placeholder (#f8f9fa) as the "Column Validations" panel's background instead of the app's darkcolors.BGSecondaryDark(#1D1E22), which clashed visibly with the rest of the (dark-themed) modal.Test plan
apps/webtype-checks cleanly (tsc --noEmit)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01Hqy3rtwmRHKRsqKY5ntuT9