ci(audience): shrink xvfb screen to 160x120 for llvmpipe fill rate#761
Closed
ImmutableJeffrey wants to merge 1 commit intochore/sdk-318-linux-playmode-xvfbfrom
Closed
ci(audience): shrink xvfb screen to 160x120 for llvmpipe fill rate#761ImmutableJeffrey wants to merge 1 commit intochore/sdk-318-linux-playmode-xvfbfrom
ImmutableJeffrey wants to merge 1 commit intochore/sdk-318-linux-playmode-xvfbfrom
Conversation
Collaborator
Author
|
Closing without merging. xvfb screen 160x120 did not reduce Unity 6 cell time (31 vs 27 min baseline). Profile data on PR #764 reveals xvfb-run --server-args was a no-op anyway (player log reports desktop 1280x1024 regardless of the screen flag). Removed in the new PR. Pixel-fill is also not the bottleneck on Unity 6 + llvmpipe; per-frame UI Toolkit cost is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-screen-widthand-screen-heighttrack the new size.Why
llvmpipe fragment-fill cost scales linearly with pixel count. The previous reduction (1280x720 to 320x240) cut fill 12x. Going to 160x120 cuts another 4x.
Risk
UI Toolkit may fail to lay out below some threshold. The SampleApp tests assert on the visual element tree, not on rendered pixels, so layout only needs to be valid; visible quality is irrelevant. If tests come back inconclusive on this PR's CI run, that means the floor is between 320x240 and 160x120 and we step back.
Experiment success criteria
🤖 Generated with Claude Code