Skip to content

chore: remove @convex-dev/auth 0.0.x tables and migration - #48

Merged
hyochan merged 1 commit into
mainfrom
chore/auth-v2-cleanup
Nov 20, 2026
Merged

hyochan merged 1 commit into
mainfrom
chore/auth-v2-cleanup

Conversation

@hyochan

@hyochan hyochan commented Nov 20, 2026

Copy link
Copy Markdown
Member

Follow-up to #47. Production ran users/migrations:migrateToAuthV2 on 2026-11-20: both users have githubAccountId and all six 0.0.x auth tables are empty (checked again before this PR).

  • Drop legacyAuthTables from the schema (verified on the dev deployment: Convex removes the empty tables' indexes).
  • Delete convex/users/migrations.ts and the authAccounts fallback in createUserFromGithub; the remaining callback tests move to test/convex/users/githubSignIn.test.ts.
  • test:dev no longer lists the old tables in its cleanup.

Checks: lint, typecheck, prettier, build, bun run test (2102 passed), check:api.

🤖 Generated with Claude Code

Production ran migrateToAuthV2 on 2026-11-20: every GitHub account is on
users.githubAccountId and the 0.0.x auth tables are empty. Drop them from the
schema, delete the migration and the authAccounts fallback in
createUserFromGithub, and stop cleaning the old tables in test:dev.

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in a7a56c1

Approved because no issues were found in fully reviewed changes. Tests were not run. Gitdog

@hyochan
hyochan merged commit 2643581 into main Nov 20, 2026
7 checks passed
@hyochan
hyochan deleted the chore/auth-v2-cleanup branch November 20, 2026 14:37
hyochan added a commit that referenced this pull request Nov 20, 2026
## Summary

Follow-ups found reviewing today's auth 2.0 work (#46, #47, #48) and
own-key cost UI (#45).

- **Connect page**: after 2.0, installation recovery reports
`reauth_required` whenever no fresh attestation exists, so a brand-new
user saw "Finishing GitHub connection" instead of Install. Users without
an installation now see Install, with "Already installed? Verify GitHub
access" as a secondary action. The verification screen is shown only
while an installation callback is pending. Screen choice moved into
`resolveConnectScreen` with a table test.
- **Usage**: the own-key section said reviews run on Gitdog tokens
whenever no key worked, but saved keys never fall back. It now
distinguishes no key / no working key / temporary outage. The page waits
for own-key cost before rendering.
- **Consent page**: shows why a GitHub sign-in failed
(`useOauth().flowError`).
- **CLI**: `github verify` reuses `validateAuthRedirect` (also handles a
missing URL); install hints mention `github verify` before `github
recover`.
- **Smaller**: `getTicketUsage` and recent own-key runs respect
`githubLifecycleOnly`; long-context price note in the model picker;
per-provider "this period" wording; shared `actionTypeLabel`;
screen-reader request count on the usage chip; unused
`repositories[].actions` removed.
- **Docs**: `getAuthUserId` import path, CLI fixed ports, verify-access
architecture line, `CUSTOM_AUTH_SITE_URL` comment.
- **Tests**: session auth rejects a bare user-id subject and a revoked
session; sign-in redirect allow/deny at the mutation; CLI port fallback
and all-ports-busy; consent flow errors. `CONVEX_CLOUD_URL` moved to
test setup.

## Verification

`bun run lint`, `typecheck`, `build`, `format:check`, `check:api`,
`typecheck:cli`, `test:cli` (118 pass), `vitest run` (2124 pass).

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant