Repository navigation
chore: remove @convex-dev/auth 0.0.x tables and migration - #48
Merged
Merged
Conversation
Production ran migrateToAuthV2 on 2026-11-20: every GitHub account is on users.githubAccountId and the 0.0.x auth tables are empty. Drop them from the schema, delete the migration and the authAccounts fallback in createUserFromGithub, and stop cleaning the old tables in test:dev.
hyochan
added a commit
that referenced
this pull request
Nov 20, 2026
## Summary Follow-ups found reviewing today's auth 2.0 work (#46, #47, #48) and own-key cost UI (#45). - **Connect page**: after 2.0, installation recovery reports `reauth_required` whenever no fresh attestation exists, so a brand-new user saw "Finishing GitHub connection" instead of Install. Users without an installation now see Install, with "Already installed? Verify GitHub access" as a secondary action. The verification screen is shown only while an installation callback is pending. Screen choice moved into `resolveConnectScreen` with a table test. - **Usage**: the own-key section said reviews run on Gitdog tokens whenever no key worked, but saved keys never fall back. It now distinguishes no key / no working key / temporary outage. The page waits for own-key cost before rendering. - **Consent page**: shows why a GitHub sign-in failed (`useOauth().flowError`). - **CLI**: `github verify` reuses `validateAuthRedirect` (also handles a missing URL); install hints mention `github verify` before `github recover`. - **Smaller**: `getTicketUsage` and recent own-key runs respect `githubLifecycleOnly`; long-context price note in the model picker; per-provider "this period" wording; shared `actionTypeLabel`; screen-reader request count on the usage chip; unused `repositories[].actions` removed. - **Docs**: `getAuthUserId` import path, CLI fixed ports, verify-access architecture line, `CUSTOM_AUTH_SITE_URL` comment. - **Tests**: session auth rejects a bare user-id subject and a revoked session; sign-in redirect allow/deny at the mutation; CLI port fallback and all-ports-busy; consent flow errors. `CONVEX_CLOUD_URL` moved to test setup. ## Verification `bun run lint`, `typecheck`, `build`, `format:check`, `check:api`, `typecheck:cli`, `test:cli` (118 pass), `vitest run` (2124 pass). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #47. Production ran
users/migrations:migrateToAuthV2on 2026-11-20: both users havegithubAccountIdand all six 0.0.x auth tables are empty (checked again before this PR).legacyAuthTablesfrom the schema (verified on the dev deployment: Convex removes the empty tables' indexes).convex/users/migrations.tsand theauthAccountsfallback increateUserFromGithub; the remaining callback tests move totest/convex/users/githubSignIn.test.ts.test:devno longer lists the old tables in its cleanup.Checks: lint, typecheck, prettier, build,
bun run test(2102 passed),check:api.🤖 Generated with Claude Code