Repository navigation
fix: post auth 2.0 follow-ups for connect, usage and cli - #49
Merged
Merged
Conversation
- Connect page offers Install to users without an installation and keeps Verify GitHub access as a secondary action; screen choice moved to a tested resolveConnectScreen - Usage shows whether saved keys work, are broken or are paused by an outage, and waits for own-key cost before rendering - Consent page explains why a GitHub sign-in failed - CLI github verify reuses the redirect check; install hints mention verify - Ticket usage hides lifecycle-only tickets; long-context price note; shared action label helper; accessible request count - Tests for session auth, sign-in redirects and CLI port fallback - Docs updated for @convex-dev/auth 2.0
|
Visit the preview URL for this PR (updated for commit 561f384): https://codeyou-df251--pr49-fix-post-migration-r-ctc2a91r.web.app (expires Fri, 27 Nov 2026 15:34:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups found reviewing today's auth 2.0 work (#46, #47, #48) and own-key cost UI (#45).
reauth_requiredwhenever no fresh attestation exists, so a brand-new user saw "Finishing GitHub connection" instead of Install. Users without an installation now see Install, with "Already installed? Verify GitHub access" as a secondary action. The verification screen is shown only while an installation callback is pending. Screen choice moved intoresolveConnectScreenwith a table test.useOauth().flowError).github verifyreusesvalidateAuthRedirect(also handles a missing URL); install hints mentiongithub verifybeforegithub recover.getTicketUsageand recent own-key runs respectgithubLifecycleOnly; long-context price note in the model picker; per-provider "this period" wording; sharedactionTypeLabel; screen-reader request count on the usage chip; unusedrepositories[].actionsremoved.getAuthUserIdimport path, CLI fixed ports, verify-access architecture line,CUSTOM_AUTH_SITE_URLcomment.CONVEX_CLOUD_URLmoved to test setup.Verification
bun run lint,typecheck,build,format:check,check:api,typecheck:cli,test:cli(118 pass),vitest run(2124 pass).🤖 Generated with Claude Code