Skip to content

fix: post auth 2.0 follow-ups for connect, usage and cli - #49

Merged
hyochan merged 1 commit into
mainfrom
fix/post-migration-review
Nov 20, 2026
Merged

hyochan merged 1 commit into
mainfrom
fix/post-migration-review

Conversation

@hyochan

@hyochan hyochan commented Nov 20, 2026

Copy link
Copy Markdown
Member

Summary

Follow-ups found reviewing today's auth 2.0 work (#46, #47, #48) and own-key cost UI (#45).

  • Connect page: after 2.0, installation recovery reports reauth_required whenever no fresh attestation exists, so a brand-new user saw "Finishing GitHub connection" instead of Install. Users without an installation now see Install, with "Already installed? Verify GitHub access" as a secondary action. The verification screen is shown only while an installation callback is pending. Screen choice moved into resolveConnectScreen with a table test.
  • Usage: the own-key section said reviews run on Gitdog tokens whenever no key worked, but saved keys never fall back. It now distinguishes no key / no working key / temporary outage. The page waits for own-key cost before rendering.
  • Consent page: shows why a GitHub sign-in failed (useOauth().flowError).
  • CLI: github verify reuses validateAuthRedirect (also handles a missing URL); install hints mention github verify before github recover.
  • Smaller: getTicketUsage and recent own-key runs respect githubLifecycleOnly; long-context price note in the model picker; per-provider "this period" wording; shared actionTypeLabel; screen-reader request count on the usage chip; unused repositories[].actions removed.
  • Docs: getAuthUserId import path, CLI fixed ports, verify-access architecture line, CUSTOM_AUTH_SITE_URL comment.
  • Tests: session auth rejects a bare user-id subject and a revoked session; sign-in redirect allow/deny at the mutation; CLI port fallback and all-ports-busy; consent flow errors. CONVEX_CLOUD_URL moved to test setup.

Verification

bun run lint, typecheck, build, format:check, check:api, typecheck:cli, test:cli (118 pass), vitest run (2124 pass).

🤖 Generated with Claude Code

- Connect page offers Install to users without an installation and keeps
  Verify GitHub access as a secondary action; screen choice moved to a
  tested resolveConnectScreen
- Usage shows whether saved keys work, are broken or are paused by an
  outage, and waits for own-key cost before rendering
- Consent page explains why a GitHub sign-in failed
- CLI github verify reuses the redirect check; install hints mention verify
- Ticket usage hides lifecycle-only tickets; long-context price note;
  shared action label helper; accessible request count
- Tests for session auth, sign-in redirects and CLI port fallback
- Docs updated for @convex-dev/auth 2.0
@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 561f384):

https://codeyou-df251--pr49-fix-post-migration-r-ctc2a91r.web.app

(expires Fri, 27 Nov 2026 15:34:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 844dad9c62537d028cabc21008e4e2e4031ce4e5

@gitdogai gitdogai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in 561f384

Approved because no issues were found in fully reviewed changes. Tests were not run. Gitdog

@hyochan
hyochan merged commit 7903910 into main Nov 20, 2026
9 checks passed
@hyochan
hyochan deleted the fix/post-migration-review branch November 20, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant