Skip to content

Test the pyproject dependency floors nightly on Python 3.11 - #7744

Closed
albertvillanova wants to merge 1 commit into
mainfrom
test-floors-python-3-11
Closed

albertvillanova wants to merge 1 commit into
mainfrom
test-floors-python-3-11

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

This PR adds a nightly job that runs the test suite with every dependency pinned exactly at its pyproject.toml floor, on Python 3.11.

Motivation

The per-PR minimum-versions job runs on Python 3.13 (#7648), where some floors have no wheels, so it pins the oldest releases that install there instead (#7741). As a result, the floors that pyproject.toml declares for 3.11 and 3.12 (#7713) are not tested anywhere.

Solution

Python 3.11 is the oldest supported Python, and every floor installs on it, so a job there can pin the floors themselves. The floors change rarely, so a nightly run in the Python versions workflow is enough, and no GPU job is added to every PR.

The pins for accelerate, datasets and transformers now appear in both minimum-versions jobs, so a floor change has to update both.

Changes

  • Add a tests_min_versions job to the nightly Python versions workflow, pinning accelerate, datasets, huggingface_hub, numpy, pandas, psutil, pyarrow, pyyaml and transformers at their floors on Python 3.11

Note

Low Risk
CI-only workflow addition with no application or runtime behavior changes.

Overview
Adds a tests_min_versions job to the nightly Tests with all supported Python versions workflow so the suite runs on Python 3.11 with key dependencies pinned to the exact pyproject.toml floor versions (accelerate, datasets, huggingface_hub, numpy, pandas, psutil, pyarrow, pyyaml, transformers).

The job mirrors the existing matrix test setup (GPU container, uv, make test) and posts results to Slack on completion. This closes the gap where the per-PR minimum-versions job on Python 3.13 cannot install every declared floor, so the true 3.11/3.12 floors were not exercised in CI until now.

Reviewed by Cursor Bugbot for commit b8f5c22. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the 🔧 maintenance CI, tooling, tests, or repo upkeep label Oct 15, 2026
@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec

Copy link
Copy Markdown
Member

Thanks! I'd rather just switch the current minimum-versions job to Python 3.11. Testing several Pythons is technically nice, but afaik we've never caught a regression specific to a Python version, so I'd rather not expand the matrix further. If I had to burn more compute on the CI, I'd rather test more torch or transformers versions instead of python version

@albertvillanova

Copy link
Copy Markdown
Member Author

Closing in favor of #7741, which moves the per-PR minimum-versions job to Python 3.11 and pins every floor there, instead of adding a second job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 maintenance CI, tooling, tests, or repo upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants