Repository navigation
Test the pyproject dependency floors nightly on Python 3.11 - #7744
Closed
albertvillanova wants to merge 1 commit into
Closed
albertvillanova wants to merge 1 commit into
albertvillanova wants to merge 1 commit into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Thanks! I'd rather just switch the current minimum-versions job to Python 3.11. Testing several Pythons is technically nice, but afaik we've never caught a regression specific to a Python version, so I'd rather not expand the matrix further. If I had to burn more compute on the CI, I'd rather test more torch or transformers versions instead of python version |
This was referenced Oct 16, 2026
Member
Author
|
Closing in favor of #7741, which moves the per-PR minimum-versions job to Python 3.11 and pins every floor there, instead of adding a second job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a nightly job that runs the test suite with every dependency pinned exactly at its
pyproject.tomlfloor, on Python 3.11.Motivation
The per-PR minimum-versions job runs on Python 3.13 (#7648), where some floors have no wheels, so it pins the oldest releases that install there instead (#7741). As a result, the floors that
pyproject.tomldeclares for 3.11 and 3.12 (#7713) are not tested anywhere.Solution
Python 3.11 is the oldest supported Python, and every floor installs on it, so a job there can pin the floors themselves. The floors change rarely, so a nightly run in the Python versions workflow is enough, and no GPU job is added to every PR.
The pins for accelerate, datasets and transformers now appear in both minimum-versions jobs, so a floor change has to update both.
Changes
tests_min_versionsjob to the nightly Python versions workflow, pinningaccelerate,datasets,huggingface_hub,numpy,pandas,psutil,pyarrow,pyyamlandtransformersat their floors on Python 3.11Note
Low Risk
CI-only workflow addition with no application or runtime behavior changes.
Overview
Adds a
tests_min_versionsjob to the nightly Tests with all supported Python versions workflow so the suite runs on Python 3.11 with key dependencies pinned to the exactpyproject.tomlfloor versions (accelerate,datasets,huggingface_hub,numpy,pandas,psutil,pyarrow,pyyaml,transformers).The job mirrors the existing matrix test setup (GPU container,
uv,make test) and posts results to Slack on completion. This closes the gap where the per-PR minimum-versions job on Python 3.13 cannot install every declared floor, so the true 3.11/3.12 floors were not exercised in CI until now.Reviewed by Cursor Bugbot for commit b8f5c22. Bugbot is set up for automated code reviews on this repo. Configure here.