Skip to content

Document that the minimum-versions CI job pins every dependency at its floor - #7745

Merged
albertvillanova merged 3 commits into
mainfrom
document-min-versions-jobs
Oct 19, 2026
Merged

albertvillanova merged 3 commits into
mainfrom
document-min-versions-jobs

Conversation

@albertvillanova

@albertvillanova albertvillanova commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

This PR documents, in the "Dependency version floors" section of the contributing guide, that the minimum-versions CI job pins every dependency at its floor, so a floor change also updates the pin.

Motivation

After #7741 the job runs on the oldest supported Python, so its pins are exactly the pyproject.toml floors. Without a written rule, a floor bump can update pyproject.toml and leave the CI pin behind, so the new floor is never tested.

Changes

  • Add a sentence to "Dependency version floors" in CONTRIBUTING.md stating that the minimum-versions job pins every floor, and that a floor change updates its pin

Note

Low Risk
Documentation-only change to CONTRIBUTING.md with no runtime or CI behavior changes.

Overview
Documents contributor workflow for dependency version floors: the minimum-versions CI job installs each dependency at its declared floor, so raising a floor in pyproject.toml must include updating that job’s pins or the new minimum is never exercised in CI.

Reviewed by Cursor Bugbot for commit 6573c92. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the 📚 documentation Improvements or additions to documentation label Oct 15, 2026
@bot-ci-comment

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
qgallouedec self-requested a review October 16, 2026 05:13
@albertvillanova albertvillanova changed the title Document how the two minimum-versions CI jobs test the dependency floors Document that the minimum-versions CI job pins every dependency at its floor Oct 16, 2026
@albertvillanova

Copy link
Copy Markdown
Member Author

I dropped "runs on the oldest supported Python" from the sentence: #7743 now states it in the "Python versions" section, next to the rule to move the job when a version is dropped. Keeping it here as well would say the same thing twice in adjacent sections, and the two copies could drift. This section keeps only the floor-side rule: a floor change also updates its pin.

@qgallouedec qgallouedec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, to merge after #7741

@albertvillanova
albertvillanova merged commit 825ba91 into main Oct 19, 2026
5 checks passed
@albertvillanova
albertvillanova deleted the document-min-versions-jobs branch October 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants