Repository navigation
Document that the minimum-versions CI job pins every dependency at its floor - #7745
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
self-requested a review
October 16, 2026 05:13
Member
Author
|
I dropped "runs on the oldest supported Python" from the sentence: #7743 now states it in the "Python versions" section, next to the rule to move the job when a version is dropped. Keeping it here as well would say the same thing twice in adjacent sections, and the two copies could drift. This section keeps only the floor-side rule: a floor change also updates its pin. |
qgallouedec
approved these changes
Oct 19, 2026
qgallouedec
left a comment
Member
There was a problem hiding this comment.
Thanks, to merge after #7741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents, in the "Dependency version floors" section of the contributing guide, that the minimum-versions CI job pins every dependency at its floor, so a floor change also updates the pin.
Motivation
After #7741 the job runs on the oldest supported Python, so its pins are exactly the
pyproject.tomlfloors. Without a written rule, a floor bump can updatepyproject.tomland leave the CI pin behind, so the new floor is never tested.Changes
CONTRIBUTING.mdstating that the minimum-versions job pins every floor, and that a floor change updates its pinNote
Low Risk
Documentation-only change to CONTRIBUTING.md with no runtime or CI behavior changes.
Overview
Documents contributor workflow for dependency version floors: the minimum-versions CI job installs each dependency at its declared floor, so raising a floor in
pyproject.tomlmust include updating that job’s pins or the new minimum is never exercised in CI.Reviewed by Cursor Bugbot for commit 6573c92. Bugbot is set up for automated code reviews on this repo. Configure here.