feat(studio): sourcePatcher data-hf-id targeting (R1, T3)#1271
Draft
Conversation
2 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Adds
hfIdas a first-class target field tosourcePatcher(packages/studio/src/utils/sourcePatcher.ts). Whentarget.hfIdis set, the patcher finds the element via[data-hf-id="${hfId}"]before falling back toidor CSS selector.Also tightens the existing
id=regex patterns with a negative lookbehind to prevent false matches on attributes likedata-id=orcomposition-id=.Why
T3 spec — the sourcePatcher path handles the studio's in-browser rich-text editing. It needs to accept
hfIdtargets so the studio can address elements by stable content-based id (R1) rather than a positional CSS selector that can drift when siblings are inserted. Depends on PR #1270.How
hfId?: stringadded to the patch target typehfId→id→selector[data-hf-id]lookup uses the same attribute-selector pattern assourceMutation(?<!\w)id=preventsdata-id=from matching id-based patternsTest plan
sourcePatcher.test.ts— hfId targeting cases pass