feat(core): clip-model hf- ids minted at parse, emitted as data-hf-id (R1)#1270
Open
vanceingalls wants to merge 1 commit into
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Wires
ensureHfIds(PR #1269) intoparseHtmlso every parsed composition gets stabledata-hf-idattributes before the element model is built.Clip model id chain:
data-hf-idis now the primary identity; existing HTMLidattrs and the counter fallback are preserved for backwards compatibility.Bridge for legacy callers:
updateElementInHtmlandremoveElementFromHtmlinhtmlParser.tsnow try[data-hf-id="${id}"]whengetElementByIdfails, so string-based callers that pass ahf-xxxxvalue continue to work without knowing about the new field.Why
Without this PR,
ensureHfIdsis a no-op — the helper exists but nothing calls it. This is the commit that makes T2 tests turn green and makes everyparseHtmlcall produce stablehf-ids. Depends on PR #1269.How
htmlParser.tsbaseline snapshots updated to reflect thehf-id format (see168c0452c).Test plan
.failstests now pass — elements gethf-prefixed ids, format matches/^hf-[a-z0-9]{4}$/, adding a sibling doesn't change existing idshtmlParser.test.tsbaselines updated and passingstableIds.test.tsbaselines (round-trip, uniqueness, existing-id preservation) still green