Repository navigation
Convert to native ESM (vitest + oxc toolchain) - #46
Merged
Merged
Conversation
Convert @hapi/b64 from CommonJS to native ESM and replace the
@hapi/lab + @hapi/code + @hapi/eslint-plugin toolchain with vitest +
@vitest/coverage-v8 and oxlint + oxfmt (via @hapi/oxc-plugin).
- "type": "module"; single "." export with a new hand-written
lib/index.d.ts (b64 previously shipped untyped); ship API.md + README.md
- convert lib/index.js, lib/encoder.js, lib/decoder.js to ESM
- engines.node >= 22; CI on the min-node-22-hapi-21 reusable workflow
Depends on the ESM @hapi/hoek; while that is unpublished the dependency
points at the wip/ts branch (github:damusix/hoek#wip/ts) and must be
repinned to a published range before release.
ESM-only — CommonJS require('@hapi/b64') no longer resolves.
damusix
force-pushed
the
esm-conversion
branch
2 times, most recently
from
June 27, 2026 03:42
34f47fd to
3dd9e04
Compare
Pure rename (no content change) so the move is tracked as a rename; reference fixups follow in the next commit.
package.json exports/types -> src/index.mjs + src/index.d.mts; vitest coverage include -> src/**; test imports -> ../src/index.mjs; b64 also updates index.mjs internal re-exports.
Replaces the github:damusix/hoek#wip/ts git dependency with the published @hapi/hoek@^12.0.0-rc.0, and raises oxlint/oxfmt to the peer floor @hapi/oxc-plugin@1.0.4 requires; the old pins fail a clean install with ERESOLVE.
hapijs#43 Co-authored-by: geek <wpreul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/index.js,lib/encoder.js,lib/decoder.js("type": "module", single.export).lib/index.d.ts—b64previously shipped without types.@hapi/lab+@hapi/code+@hapi/eslint-plugin→vitest+@vitest/coverage-v8+oxlint+oxfmt(shared@hapi/oxc-pluginconfig).engines.nodeto>= 22; move CI to themin-node-22-hapi-21reusable workflow.What this solves
Wave-2 package of the hapi ESM migration (deps already ESM), on the
bourneJS-ESM archetype. 100% coverage preserved under vitest; the new.d.tsmatches the runtime surface (decode/encode/Decoder/Encoder/base64urlEncode/base64urlDecode).Important
The
@hapi/hoekdependency is a temporary pre-publish pointer. It is set togithub:damusix/hoek#wip/tsbecause the ESM@hapi/hoekis not on npm yet. This installs cleanly (npm builds it via hoek'sprepare) and is safe becauseb64uses only hoek's main export (Hoek.assert), not the per-function subpath exports. It must be repinned to a published semver range before merge/release — a git-branch dependency cannot ship to npm.ESM-only: drops the CommonJS build (breaking for
require()consumers). Version bump left to the release process.