Repository navigation
Conversation
devinivy
approved these changes
Jul 30, 2023
kanongil
reviewed
Jul 31, 2023
There was a problem hiding this comment.
This can break for people who are still on pre node v14.18.0, which this release line is supposed?? to support.
Given that node will soon only support v18+ (v16 is EOL in little over a month), it will probably be better to just defer this PR till a breaking change that targets v18+.
Marsup
added a commit
to damusix/b64
that referenced
this pull request
Oct 28, 2026
hapijs#43 Co-authored-by: geek <wpreul@gmail.com>
Marsup
added a commit
that referenced
this pull request
Oct 28, 2026
#43 Co-authored-by: geek <wpreul@gmail.com>
Contributor
|
Thanks a lot! I included it as part of #46 and gave you credit in the commit, I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37