feat(site): add branded navigation and theme controls - #708
Conversation
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). Reviewed |
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
Review follow-up in 28f0ab2ee6f8d3bd12b858cbd849b2cb13e2c8c4 (fixup of dce9173). Read all paginated feedback: one review, one inline thread and one conversation summary containing four additional findings. All five findings are accounted for:
Validation: make generate succeeded in a temporary checkout with the required module-path suffix and produced no generated drift; make site, make lint docs, node --check and git diff --check passed. Browser comparisons confirmed all 71 token/container styles retain their original colors, and 27 page selectors retain their colors, borders and shadows across six combinations of theme choice and system preference. Selection dismissal, focus return and Escape were checked in the existing localhost:1313 preview. No documentation tests were added. The fixup is left standing for squash merge. CI for the updated head will run after push. |
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
Second review follow-up in 66c05de (fixup of dce9173). The latest run emitted two findings: one inline browser-compatibility finding and one summary-only .bg finding. Both are addressed:
Validation: make site and make lint docs passed; make generate in a temporary checkout produced no generated drift. Browser comparisons against the original CSS confirmed all 71 token/container styles and 27 page selectors retain their original colors across the six combinations of Light/Dark/System choice and light/dark system preference. The .bg rule was checked in all six combinations and follows the code background. No documentation tests were added. The existing localhost:1313 preview remains running. This is a separate fixup; the earlier fixup remains in history for squash merge. Updated-head CI will run after push. |
Signed-off-by: thxCode <thxcode0824@gmail.com>
|
Third review follow-up in 02660b7 (fixup of dce9173). Read all feedback again: four reviews, four inline comments including replies, and three conversation comments. The latest run emitted three summary-only findings:
Validation: make generate produced no generated drift; make site, make lint docs, node --check and git diff --check passed. All 71 syntax styles match the original palette in six manual/System combinations, and the shared code background follows the selected theme. No documentation tests were added. All ten findings from the three completed review runs now have an outcome in this conversation. The two actual inline threads remain resolved. This fixup stays with the earlier fixups for squash merge; localhost:1313 remains running. |
What type of PR is this?
/kind enhancement
/kind documentation
/area integrations
What this PR does / why we need it:
Which issue(s) this PR links to:
NONE
Special notes for your reviewer:
make site,make lint docs, the production-path site build and JavaScript syntax check passed. No documentation tests were added.target="_blank"andrel="noopener noreferrer"; clicking it retained the article URL.Does this PR introduce a user-facing change?