fix(logging-utils): export LogSeverity as value and treat 'true' as '*' alias

core/packages/logging-utils/src/index.ts

@@ -14,9 +14,5 @@
 
 export * from './logging-utils';
 // 🌟 ADDED EXPORT FOR TYPES 🌟
-export type {
-  LogFields,
-  LogSeverity,
-  AdhocDebugLogFunction,
-  DebugLogBackend,
-} from './types';
+export {LogSeverity} from './types';
+export type {LogFields, AdhocDebugLogFunction, DebugLogBackend} from './types';

core/packages/logging-utils/src/logging-utils.ts

@@ -123,7 +123,7 @@ export abstract class DebugLogBackendBase implements DebugLogBackend {
     // Look for the Node config variable for what systems to enable. We'll store
     // these for the log method below, which will call setFilters() once.
     let nodeFlag = process.env[env.nodeEnables] ?? '*';
-    if (nodeFlag === 'all') {
+    if (nodeFlag === 'all' || nodeFlag === 'true') {
       nodeFlag = '*';
     }
     this.filters = nodeFlag.split(',');

core/packages/logging-utils/test/logging-utils.ts

@@ -16,7 +16,7 @@
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 
-import * as al from '../src/logging-utils';
+import * as al from '../src/index';
 import * as alTypes from '../src/types';
 
 interface TestLog {
@@ -28,7 +28,7 @@
 class TestSink extends al.DebugLogBackendBase {
   logs: TestLog[] = [];
 
   makeLogger(namespace: string): any {
     return (fields: alTypes.LogFields, ...args: unknown[]) => {
       this.logs.push({namespace, fields, args});
     };
@@ -57,13 +57,29 @@
     });
 
     it('obeys "all" as an alias for "*"', () => {
-      al.setBackend(sink);
-      sink.reset();
-
       process.env[al.env.nodeEnables] = 'all';
+      const backend = new TestSink();
+      al.setBackend(backend);
+      assert.deepStrictEqual(backend.filters, ['*']);
       const logger = al.log(system);
       logger({}, 'foo');
-      assert.deepStrictEqual(sink.logs, [
+      assert.deepStrictEqual(backend.logs, [
+        {
+          namespace: system,
+          fields: {},
+          args: ['foo'],
+        },
+      ]);
+    });
+
+    it('obeys "true" as an alias for "*"', () => {
+      process.env[al.env.nodeEnables] = 'true';
+      const backend = new TestSink();
+      al.setBackend(backend);
+      assert.deepStrictEqual(backend.filters, ['*']);
+      const logger = al.log(system);
+      logger({}, 'foo');
+      assert.deepStrictEqual(backend.logs, [
         {
           namespace: system,
           fields: {},
@@ -74,7 +90,7 @@
   });
 
   describe('Manually enabled', () => {
     let logger: any;
     const system = 'basic';
 
     beforeEach(() => {
@@ -98,7 +114,7 @@
   });
 
   describe('Basic enabled', () => {
     let logger: any;
     const system = 'basic';
 
     beforeEach(() => {
@@ -176,7 +192,7 @@
   });
 
   describe('Tap', () => {
     let logger: any;
     const system = 'taps';
 
     beforeEach(() => {
@@ -207,7 +223,7 @@
     const system = 'structured';
     const structured = al.getStructuredBackend(sink);
 
     let logger: any;
     beforeEach(() => {
       al.setBackend(structured);
       sink.reset();
@@ -273,7 +289,7 @@
   });
 
   describe('sub-logs', () => {
     let logger: any;
     const system = 'sublogs';
     const subsystem = 'subsys';
 
@@ -297,4 +313,12 @@
       ]);
     });
   });
+
+  it('exports LogSeverity as a runtime enum from index', () => {
+    assert.strictEqual(al.LogSeverity.DEFAULT, 'DEFAULT');
+    assert.strictEqual(al.LogSeverity.DEBUG, 'DEBUG');
+    assert.strictEqual(al.LogSeverity.INFO, 'INFO');
+    assert.strictEqual(al.LogSeverity.WARNING, 'WARNING');
+    assert.strictEqual(al.LogSeverity.ERROR, 'ERROR');
+  });
 });