Repository navigation
fix(logging-utils): export LogSeverity as value and treat 'true' as '*' alias - #9718
Open
shivanee-p wants to merge 2 commits into
Open
shivanee-p wants to merge 2 commits into
shivanee-p wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the logging-utils package to export LogSeverity as a runtime enum from the index and adds support for treating the "true" environment variable flag as an alias for "*". It also updates the test suite to import from the package index and adds tests for these new behaviors. The review feedback identifies an issue in the new tests where assertions are made on a stale global sink instance instead of the updated configuration; it is recommended to re-assign and register the global sink to ensure the tests are robust and correctly verify the integration.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports
LogSeverityas a runtime value and treats"true"as"*"Changes:
LogSeverityas a value instead ofexport typeinsrc/index.tsnodeFlag === 'true'to'*'inDebugLogBackendBaseLogSeverityexports and"true"filter normalization.