Skip to content

Return configured block size from FileStore.getBlockSize() #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanvir-ux wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −0
Open

Return configured block size from FileStore.getBlockSize() #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323ad4c
Return configured block size from FileStore.getBlockSize().
tanvir-ux Aug 27, 2026
22fdf63
Drop extra javadoc and reflective FileStore.getBlockSize() test.
tanvir-ux Aug 27, 2026
1d48db5
Remove redundant FileStore getBlockSize configuration test.
tanvir-ux Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jimfs/src/main/java/com/google/common/jimfs/JimfsFileStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,12 @@ public long getUnallocatedSpace() throws IOException {
return disk.getUnallocatedSpace();
}

@SuppressWarnings("MissingOverride") // FileStore.getBlockSize() is Java 10+
public long getBlockSize() throws IOException {
state.checkOpen();
return disk.blockSize();
}

@Override
public boolean supportsFileAttributeView(Class<? extends FileAttributeView> type) {
state.checkOpen();
Expand Down
2 changes: 2 additions & 0 deletions jimfs/src/test/java/com/google/common/jimfs/ConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ public void testFileSystemForCustomConfiguration() throws IOException {
assertThat(fs.supportedFileAttributeViews()).containsExactly("basic", "owner", "posix", "unix");

Files.createFile(fs.getPath("/foo"));
assertThat(((JimfsFileStore) Iterables.getOnlyElement(fs.getFileStores())).getBlockSize())
.isEqualTo(10);
assertThat(Files.getAttribute(fs.getPath("/foo"), "posix:permissions"))
.isEqualTo(PosixFilePermissions.fromString("---------"));
assertThat(Files.getAttribute(fs.getPath("/foo"), "creationTime"))
Expand Down
3 changes: 3 additions & 0 deletions jimfs/src/test/java/com/google/common/jimfs/JimfsUnixLikeFileSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ public void testFileStore() throws IOException {

long totalSpace = 1024 * 1024 * 1024; // 1 GB
assertThat(fileStore.getTotalSpace()).isEqualTo(totalSpace);
// Default unix block size; FileStore.getBlockSize() is Java 10+, so call the Jimfs method
// directly (same package) so this still compiles on Java 8.
assertThat(((JimfsFileStore) fileStore).getBlockSize()).isEqualTo(8192);
assertThat(fileStore.getUnallocatedSpace()).isEqualTo(totalSpace);
assertThat(fileStore.getUsableSpace()).isEqualTo(totalSpace);

Expand Down