Return configured block size from FileStore.getBlockSize() - #511
Open
tanvir-ux wants to merge 3 commits into
Open
Return configured block size from FileStore.getBlockSize()#511tanvir-ux wants to merge 3 commits into
tanvir-ux wants to merge 3 commits into
Conversation
Jimfs stored the block size on HeapDisk but never overrode FileStore.getBlockSize(), so JDK 10+ callers got UnsupportedOperationException even after Configuration.setBlockSize(). Fixes google#183
chaoren
reviewed
Aug 27, 2026
chaoren
reviewed
Aug 27, 2026
chaoren
reviewed
Aug 27, 2026
Covered by testFileSystemForCustomConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileStore.getBlockSize()was added in Java 10. Jimfs already keeps the configured size onHeapDisk(Configuration.setBlockSize), butJimfsFileStorenever overrode the JDK method, so callers always gotUnsupportedOperationException.This implements
getBlockSize()by returningdisk.blockSize(). There is no@Overrideso the project still compiles on Java 8; on 10+ it overrides at runtime.Fixes #183
The new test matches the repro from the issue (unix config,
setBlockSize(1 << 12)). Direct calls go throughJimfsFileStore.getBlockSize()so they compile on 8; a reflective call coversFileStore.getBlockSize()on 10+ and is skipped on 8.