Repository navigation
feat(canvas): complete Pick & polish experience - #42
Merged
Merged
Conversation
Keep creator note synchronization separate from review conversations and learning. Preserve append-only thread history, owner snapshots, revision guards, and deletion tombstones. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33
Extract the local improvement runtime, guarded actions, immutable batches and Hub synchronization from the frozen Pick & polish source. Keep renderer changes for the next layer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Extract the final canvas selection, saved-thread presentation, and UI polish layer over the guarded actions and synchronization contracts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Contributor
Author
|
Isolated Storybook presentation: saved conversation with human follow-ups and Copilot history. The fixture does not represent a live prototype or Hub account.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
2 open issues
4 files not reviewed
.github/extensions/replica-prototype/assets/renderer-improvement-notes-prototype.js: Generated file.github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js: Generated file.github/extensions/replica-prototype/assets/renderer-prototype-canvas-thread-sample.js: Generated file.github/extensions/replica-prototype/assets/renderer-rolldown-runtime.js: Generated file
What changed in this PR
Adds the Pick & polish canvas interface on top of #41’s persistence and explicit Copilot handoff contracts.
Changes:
- Adds live selection, saved pins, conversations and human follow-ups.
- Shares review presentation and updates toolbar, counters and Controls help.
- Adds fixtures, tests, documentation and generated extension chunks.
Full suites and rendered checks remain unverified.
| File | Description |
|---|---|
| hub/vite.prototype-canvas.config.mjs | Updated as part of this pull request. |
| hub/docs/storybook.md | Updated as part of this pull request. |
| hub/docs/review-collaboration.md | Updated as part of this pull request. |
| hub/docs/prototype-canvas.md | Updated as part of this pull request. |
| hub/app/javascript/utils/prototype-canvas/types.ts | Updated as part of this pull request. |
| hub/app/javascript/utils/prototype-canvas/en.ts | Updated as part of this pull request. |
| hub/app/javascript/tokens/base.css | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-reply-form/types.ts | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-reply-form/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-message/styles.css | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-message/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-conversation/styles.css | Updated as part of this pull request. |
| hub/app/javascript/features/review-thread-conversation/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/review-comment-reactions/styles.css | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-thread-sample/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-thread-sample/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-thread-sample/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-thread-sample/fixtures.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-thread-sample/en.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/types.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/styles.css | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-threads/en.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/use-saved-notes/index.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/use-saved-notes/index.test.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/use-preview-selection/index.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/types.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/thread-view/index.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/thread-view/index.test.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/styles.css | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/preview/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/fixtures.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/en.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-improvement-notes/capture/index.ts | Updated as part of this pull request. |
| hub/app/javascript/features/prototype-canvas-hub-panel/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/review-message-heading/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/review-message-heading/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/review-conversation-frame/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/review-conversation-frame/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-controls-panel/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-controls-panel/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-controls-panel/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-controls-panel/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-canvas-toolbar/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-canvas-toolbar/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-canvas-toolbar/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-canvas-toolbar/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-canvas-dialog/index.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-build-details-dialog/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/prototype-build-details-dialog/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/hub-counter/styles.css | Updated as part of this pull request. |
| hub/app/javascript/components/hub-counter/stories.tsx | Updated as part of this pull request. |
| hub/app/javascript/components/hub-counter/index.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-preview-bridge/index.ts | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-preview-bridge/index.test.ts | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-preview-bridge/improvement-selection.test.ts | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-canvas/tests/counters.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-canvas/tests/appearance.test.tsx | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-canvas/styles.css | Updated as part of this pull request. |
| hub/app/javascript/application/prototype-canvas/index.tsx | Updated as part of this pull request. |
| .github/extensions/replica-prototype/start-canvas-server/index.test.mjs | Updated as part of this pull request. |
| .github/extensions/replica-prototype/start-canvas-server/index.mjs | Updated as part of this pull request. |
| .github/extensions/replica-prototype/register-prototype-canvas/index.mjs | Updated as part of this pull request. |
| .github/extensions/replica-prototype/assets/renderer-rolldown-runtime.js | Updated as part of this pull request. |
| .github/extensions/replica-prototype/assets/renderer-prototype-canvas-thread-sample.js | Updated as part of this pull request. |
| .github/extensions/replica-prototype/assets/renderer-prototype-canvas-improvement-threads.js | Updated as part of this pull request. |
Review effort: Max
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03c141fe-2f30-4317-81df-1051bac1d3ab
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 03c141fe-2f30-4317-81df-1051bac1d3ab
Paginate note-bearing collections within a 2 MiB JSON budget before loading capture payloads. Reject malformed scalars, reflect write access in note capabilities, and accept immutable owner snapshots captured before a login rename. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33
Reserve serialized answers, preserve unattributed originals, invalidate retried batch requests, isolate per-note sync conflicts and traverse complete paginated collections before synchronizing. Keep canonical anchor geometry and explicit URL reopen semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Forward authenticated preview dismissal through the existing draft-protected conversation path. Validate captured collection identity and note revision before Retry or Return to active, with regression coverage and regenerated renderer assets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Merge the updated lower-layer contracts to resolve the reported PR base conflict and validate the runtime against bounded collection reads and historical owner snapshots. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge shipped main fixes while retaining both the protected-note persistence regression and publishing-failure regression at their shared insertion point. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge the final validated actions layer while retaining the complete canvas experience and review fixes. Preserve both skill discovery coverage and current plugin metadata, reconcile the canonical guide, and regenerate conflicting renderer assets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Use the normal semantic foreground and semibold author for unresolved improvement rows, leaving resolved and genuinely disabled states distinct. Match ordinary comment hover gutters without moving text or reducing selection targets, with light/dark desktop/mobile renderer regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture source when selecting a target and require a matching published Build before initial synchronization. Retain its identity across retries, follow-ups, and deletion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the live adapter and small presentation stories, replace cosmetic assertions with a functional renderer smoke, and minify the generated anchor validator through the existing Vite build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve overlapping local-review capture, Hub client renames, canvas selection and documentation changes. Rebuild generated bridge and renderer assets from the merged source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture source before target selection and require a matching successful published Build. Save the initial Build before dispatching an upload and retain it for later changes. Minify the generated anchor validator through the existing Vite build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the existing UI layer while integrating relational comments, publication-gated runtime storage and current main. Keep the canonical guide aligned with the separate comment models and immutable Build contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain the live-only adapter, small component stories and functional renderer smoke in the existing UI PR. Preserve the revised persistence and publication contracts from its parent layers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 21, 2026
Remove unshipped conversation versions and collection limits. Keep complete-feed consumers aligned with the persistence contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrate the updated persistence layer and use one current conversation contract. Remove legacy conversion, collection budgets and paginated batch retrieval while preserving identity, revision and source guards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrate the simplified synchronization layer and align UI, batch instructions and generated assets with the current conversation contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the persistence UUID validation and main's reviewer-profile import, then regenerate renderer assets from the combined source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33
Regenerate the renderer from combined persistence and current main source after the review layout update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge the validated actions parent, retain the latest Pick and polish conversation refinements, and regenerate the conflicting renderer assets from combined source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Lift only the row owning an expanded action menu within the existing sidebar scroll boundary. Cover actual sibling overlap, hover, pointer actions, focus, and scrolling in the packaged renderer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Remove the unused unread gutter from improvement rows, align avatars with the Active notes control, and inset actions like ordinary comments. Preserve hover gutters and full action targets with rendered geometry coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
nshki
approved these changes
Oct 22, 2026
lukasoppermann
added a commit
that referenced
this pull request
Oct 22, 2026
<!-- Use a conventional commit-style title, such as "fix(hub): retain prototype history". --> ## Why <!-- Explain the problem and why this change matters in a short, plain-English paragraph. Link the issue when applicable. --> Prototype authors need to retain Pick & polish requests and Copilot answers without turning private improvement work into team review conversations. This is the server foundation of the Pick & polish stack, extracted from #13; local synchronization and the canvas interface follow separately. ## What changes <!-- Describe what becomes different for a first-time reader. Explain necessary terms. Include accurate Mermaid diagrams when they clarify the proposal, using before/after diagrams when helpful. Add screenshots for meaningful UI changes. --> <!-- Omit validation sections, checklists, and routine test/CI summaries such as "CI is green" or "tests passed". Mention only known verification gaps that affect the change, not disclaimers about drafting this description. --> Hub stores each request or agent response in a separate `ImprovementComment` row, not in `ReviewComment`. Foreign keys connect replies to their original request, and `ImprovementCommentReply` links an agent response to the requests it answers. The API returns one current `thread` shape, assembled from these records rather than stored as a JSON conversation or lists of IDs. Synchronization validates and saves the conversation in one transaction. Initial uploads require a successful Build. Unpublished notes remain on the author's device until the client verifies that their captured source was published; later changes retain the original Build. The paired API checks repository access, saves only the authenticated creator's notes, and rejects stale or conflicting revisions. Notes remain outside ordinary review interfaces, summaries, unread state, notifications, analytics and learning. Paired comment lists must explicitly request them. Conversations preserve the original request, follow-ups, answers and immutable owner snapshots without legacy conversions, version negotiation or speculative collection limits. Creator and raw comment feeds return complete collections; existing browser and agent readers use that contract. Compact agent output retains its separate pagination. Deletion clears message text and author snapshots while retaining tombstones. The unshipped relational migration and API guide are updated together; development databases that ran an earlier copy need a fresh database or a deliberate rollback and reapply after preserving needed data. Local synchronization and the canvas interface remain in #41 and #42. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33
Preserve improvement runtime documentation and sample flag transport in the canonical TypeScript context while adopting the shared extension module build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Base automatically changed from
lukasoppermann-improvement-actions-and-sync
to
main
October 22, 2026 15:12
lukasoppermann
added a commit
that referenced
this pull request
Oct 22, 2026
<!-- Use a conventional commit-style title, such as "fix(hub): retain prototype history". --> ## Why <!-- Explain the problem and why this change matters in a short, plain-English paragraph. Link the issue when applicable. --> Pick & polish needs to retain authors' requests across canvas reloads and pass only explicitly selected work to Copilot. This is the second extraction from #13, built on the Hub persistence contracts in #39. ## What changes <!-- Describe what becomes different for a first-time reader. Explain necessary terms. Include accurate Mermaid diagrams when they clarify the proposal, using before/after diagrams when helpful. Add screenshots for meaningful UI changes. --> <!-- Omit validation sections, checklists, and routine test/CI summaries such as "CI is green" or "tests passed". Mention only known verification gaps that affect the change, not disclaimers about drafting this description. --> The extension stores notes in private local files, preserves conversation history and saved author identity, and synchronizes revisions with Hub without registering or publishing a prototype. Guarded HTTP and canvas actions reject stale checkout, account and note state. Shared identity validators accept Enterprise Managed User logins containing underscores. Notes without saved author snapshots remain unattributed rather than being claimed automatically. Clients capture the local source before selecting a target. New notes stay local until a successful published Build matches that exact source and was published after the note was saved. Capture failures and older notes without provenance remain usable locally, with an explicit synchronization limitation. The client saves the chosen Build before its first upload, so an uncertain result or restart cannot bind another Build; follow-ups, status changes and deletion retain it. Explicit fix requests save immutable batches before handing work to Copilot. Results update only captured requests still awaiting answers and return a small acknowledgment; later follow-ups remain separate work. Synchronization and batch retrieval read complete collections. Local storage and Hub use one current conversation shape without legacy conversion, version negotiation, screenshots or speculative collection and history limits. The anchor validator is generated from readable Hub source and minified with the existing Vite pipeline used by the preview bridge and Controls validator. Renderer, selection bridge and visible UI changes remain in #42; this PR does not enable a new canvas interface. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33 Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge the validated actions parent, retaining both the Pick & polish experience and canonical typed extension sources. Reconcile Controls state stories and guide coverage, and remove the duplicate toolbar story introduced by the automatic merge. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
Integrate main after the actions parent was squash-merged, preserving the verified parent tree and all upper-layer UI behavior alongside the newly landed build-link changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 96b94d6f-ee24-4ed6-861e-c1005213ed83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prototype authors need to select improvements in the live preview and discuss follow-ups without losing earlier requests or Copilot answers. This is the final UI layer over #41, extracted from #13 without changing its backend or local-storage contracts.
What changes
Pick & polish adds element and region selection, saved pins, conversations, human follow-ups, and explicit Fix all requests. Pins and conversations render the complete collection without silent truncation or legacy conversion. Shared conversation components preserve ordinary review metadata and actions. The accepted toolbar, Controls help link, avatars, and draft protections are included with regenerated extension assets and the complete guide.
Starting target selection captures the source through #41's runtime API. Saving never replaces that capture. New improvements stay local until a matching successful Build is published; later follow-ups and deletion retain the same Build.
Fix all uses the bundled, discoverable
/replica-pick-and-polishskill. Its request contains checkout and batch metadata; the skill retrieves all captured notes and conversation history in one response. Notes retain target metadata, not screenshots. Sessions without an available skill use the same bundled procedure inline. Preparation errors stop dispatch without leaving a pending batch.The standalone Storybook prototype app is removed. Small fixtures use the real conversation component rather than recreating selection, storage and agent behavior. The packaged-renderer check covers one functional flow instead of asserting colors, spacing or pixels. Human visual review uses the screenshots below.
The retained live conversation and sidebar, captured through the packaged renderer with a local fixture preview and simulated agent answers:
These screenshots use the packaged renderer in an isolated fixture. The independent connection identity change in #40 remains outside this stack; unavailable immutable viewer identity is reported as an attribution error. Formal accessibility review remains deferred as requested. Native-host rendering and deployed authenticated Build behavior are not established by the isolated fixture checks.