feat(hub): persist improvement conversations by lukasoppermann · Pull Request #39 · github/replica

lukasoppermann · 2026-10-20T09:59:54Z

Why

Prototype authors need to retain Pick & polish requests and Copilot answers without turning private improvement work into team review conversations. This is the server foundation of the Pick & polish stack, extracted from #13; local synchronization and the canvas interface follow separately.

What changes

Hub stores each request or agent response in a separate ImprovementComment row, not in ReviewComment. Foreign keys connect replies to their original request, and ImprovementCommentReply links an agent response to the requests it answers. The API returns one current thread shape, assembled from these records rather than stored as a JSON conversation or lists of IDs. Synchronization validates and saves the conversation in one transaction.

Initial uploads require a successful Build. Unpublished notes remain on the author's device until the client verifies that their captured source was published; later changes retain the original Build. The paired API checks repository access, saves only the authenticated creator's notes, and rejects stale or conflicting revisions. Notes remain outside ordinary review interfaces, summaries, unread state, notifications, analytics and learning. Paired comment lists must explicitly request them.

Conversations preserve the original request, follow-ups, answers and immutable owner snapshots without legacy conversions, version negotiation or speculative collection limits. Creator and raw comment feeds return complete collections; existing browser and agent readers use that contract. Compact agent output retains its separate pagination. Deletion clears message text and author snapshots while retaining tombstones. The unshipped relational migration and API guide are updated together; development databases that ran an earlier copy need a fresh database or a deliberate rollback and reapply after preserving needed data. Local synchronization and the canvas interface remain in #41 and #42.

Keep creator note synchronization separate from review conversations and learning. Preserve append-only thread history, owner snapshots, revision guards, and deletion tombstones. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33

Copilot

🟡 Changes recommended

The new persistence API has unresolved correctness and memory-use issues.

5 open issues

What changed in this PR

Adds Hub persistence for creator-owned Pick & polish notes, preparing for later local synchronization and canvas UI work.

Changes:

Adds revision-guarded note APIs, versioned threads and permanent deletion tombstones.
Separates improvement notes from ordinary reviews and learning.
Adds migrations, regression coverage and API documentation.

File	Description
`hub/test/models/review_comment_note_thread_test.rb`	Tests thread validation, immutable history and deletion.
`hub/test/models/learning/run_test.rb`	Tests exclusion from learning scheduling.
`hub/test/integration/canvas_repository_comments_test.rb`	Covers synchronization, visibility and request limits.
`hub/test/integration/canvas_improvement_note_threads_test.rb`	Covers thread revisions, compatibility and ownership.
`hub/docs/review-collaboration.md`	Explains separation from review conversations.
`hub/docs/prototype-canvas.md`	Documents note persistence contracts.
`hub/db/schema.rb`	Records note fields, indexes and constraints.
`hub/db/migrate/20261019140000_add_note_thread_to_review_comments.rb`	Adds constrained thread storage.
`hub/db/migrate/20261013080000_add_improvement_notes_to_review_comments.rb`	Adds note identity and persistence fields.
`hub/config/routes.rb`	Adds note read and save routes.
`hub/app/models/review_comment/note_thread_contract.rb`	Validates thread formats, snapshots and history.
`hub/app/models/review_comment.rb`	Adds note validation, scopes and lifecycle handling.
`hub/app/models/prototype.rb`	Separates review and note associations.
`hub/app/models/learning/run.rb`	Excludes notes from learning eligibility.
`hub/app/models/learning/overview.rb`	Excludes notes from learning evidence.
`hub/app/models/learning/collection.rb`	Excludes notes from learning imports.
`hub/app/controllers/concerns/review_comment_pages.rb`	Adds note filtering and serialization.
`hub/app/controllers/concerns/review_comment_actions.rb`	Rejects threads through ordinary comment writes.
`hub/app/controllers/concerns/has_review_comment_context.rb`	Shares filtering, payload guards and request limits.
`hub/app/controllers/canvas_api/repository_review_comments_controller.rb`	Supports explicit note inclusion.
`hub/app/controllers/canvas_api/prototypes_controller.rb`	Exposes the authenticated viewer ID.
`hub/app/controllers/canvas_api/improvement_notes_controller.rb`	Implements creator-scoped reads and guarded saves.

_{Review effort: Max}

Paginate note-bearing collections within a 2 MiB JSON budget before loading capture payloads. Reject malformed scalars, reflect write access in note capabilities, and accept immutable owner snapshots captured before a login rename. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove unshipped conversation versions and collection limits. Keep complete-feed consumers aligned with the persistence contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Preserve the persistence UUID validation and main's reviewer-profile import, then regenerate renderer assets from the combined source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33

Regenerate the renderer from combined persistence and current main source after the review layout update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33

## Why  Pick & polish needs to retain authors' requests across canvas reloads and pass only explicitly selected work to Copilot. This is the second extraction from #13, built on the Hub persistence contracts in #39. ## What changes   The extension stores notes in private local files, preserves conversation history and saved author identity, and synchronizes revisions with Hub without registering or publishing a prototype. Guarded HTTP and canvas actions reject stale checkout, account and note state. Shared identity validators accept Enterprise Managed User logins containing underscores. Notes without saved author snapshots remain unattributed rather than being claimed automatically. Clients capture the local source before selecting a target. New notes stay local until a successful published Build matches that exact source and was published after the note was saved. Capture failures and older notes without provenance remain usable locally, with an explicit synchronization limitation. The client saves the chosen Build before its first upload, so an uncertain result or restart cannot bind another Build; follow-ups, status changes and deletion retain it. Explicit fix requests save immutable batches before handing work to Copilot. Results update only captured requests still awaiting answers and return a small acknowledgment; later follow-ups remain separate work. Synchronization and batch retrieval read complete collections. Local storage and Hub use one current conversation shape without legacy conversion, version negotiation, screenshots or speculative collection and history limits. The anchor validator is generated from readable Hub source and minified with the existing Vite pipeline used by the preview bridge and Controls validator. Renderer, selection bridge and visible UI changes remain in #42; this PR does not enable a new canvas interface. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33 Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c

lukasoppermann requested review from a team and nshki as code owners October 20, 2026 09:59

Copilot AI max review requested due to automatic review settings October 20, 2026 09:59

Copilot started reviewing on behalf of lukasoppermann October 20, 2026 10:00

View session

lukasoppermann mentioned this pull request Oct 20, 2026

feat(canvas): persist improvement actions and synchronization #41

Merged

Copilot AI reviewed Oct 20, 2026

View reviewed changes

lukasoppermann added this pull request to stack #43 October 20, 2026 10:27

lukasoppermann mentioned this pull request Oct 20, 2026

feat(canvas): add Pick & polish for prototype feedback #13

Closed

lukasoppermann and others added 2 commits October 20, 2026 15:11

refactor(hub): separate published improvement comments

af9467b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Oct 20, 2026

refactor(hub): separate published improvement comments #48

Merged

Copilot AI added 2 commits October 21, 2026 01:48

chore(hub): merge main into improvement persistence

d471eab

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

refactor(hub): simplify improvement persistence and comment feeds

55148ba

Remove unshipped conversation versions and collection limits. Keep complete-feed consumers aligned with the persistence contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI changed the title ~~feat(hub): persist versioned improvement notes~~ feat(hub): persist improvement conversations Oct 21, 2026

lukasoppermann and others added 2 commits October 22, 2026 07:41

chore(hub): merge current review layout changes

52b1403

Regenerate the renderer from combined persistence and current main source after the review layout update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b55e539f-c9ba-4320-b39f-bf94f18c0f33

nshki approved these changes Oct 22, 2026

View reviewed changes

lukasoppermann merged commit b11cd0b into main Oct 22, 2026
40 checks passed

lukasoppermann deleted the lukasoppermann-improvement-persistence-contracts branch October 22, 2026 14:54

Navigation Menu

Repository navigation

feat(hub): persist improvement conversations - #39

feat(hub): persist improvement conversations#39
lukasoppermann merged 7 commits into
mainfrom
lukasoppermann-improvement-persistence-contracts

lukasoppermann commented Oct 20, 2026 •

edited by Copilot AI

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

lukasoppermann commented Oct 20, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lukasoppermann commented Oct 20, 2026 •

edited by Copilot AI

Loading