Skip to content

fix(shared-issues): Use hard navigation for Details link to prevent missing org context #128735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −3
Open

fix(shared-issues): Use hard navigation for Details link to prevent missing org context #128735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8aae79
fix(shared-issues): Use hard navigation for Details link to prevent m…
sentry[bot] Oct 24, 2026
ef71372
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion static/app/views/sharedGroupDetails/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,18 @@ describe('SharedGroupDetails', () => {
route: '/organizations/:orgId/share/issue/:shareId/',
},
});
expect(await screen.findByText('Details')).toBeInTheDocument();
// The "Details" link must be a hard-navigation anchor (not a React Router
// Link) so clicking it triggers a full page load and the issue detail route
// boots with the correct org context. An in-app navigation would unmount
// this page's OrganizationContext, leaving child components that call
// useOrganization() with a null context and causing them to throw.
const detailsLink = await screen.findByRole('link', {name: 'Details'});
expect(detailsLink).toBeInTheDocument();
expect(detailsLink.tagName).toBe('A');
expect(detailsLink).toHaveAttribute(
'href',
'https://foo.io/organizations/foo/issues/1234/'
);
expect(await screen.findByTestId('sgh-timestamp')).toBeInTheDocument();
});

Expand Down
9 changes: 7 additions & 2 deletions static/app/views/sharedGroupDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,14 @@ function SharedGroupDetails() {
<span className="icon-sentry-logo-full" />
</Link>
{group.permalink && (
<Link className="details" to={group.permalink}>
// Use a hard navigation (not React Router in-app nav) so the
// app re-bootstraps with the correct org context. An in-app
// navigation unmounts this page's OrganizationContext before
// the issue detail route has a chance to load its own, causing
// useOrganization() calls in child components to throw.
<a className="details" href={group.permalink}>
{t('Details')}
</Link>
</a>
)}
</div>
<div className="box-content">
Expand Down
Loading