Repository navigation
fix(shared-issues): Use hard navigation for Details link to prevent missing org context - #128735
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
…issing org context
github-actions
Bot
added
the
Scope: Frontend
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When viewing a shared issue at
/share/issue/:shareId/, the user is typically unauthenticated or outside the target organization's membership. The shared view renders under a local, minimalOrganizationContext.Previously, the "Details" button in
SharedGroupDetailsused a React Router<Link to={group.permalink}>. Clicking it triggered an in-app client-side SPA transition to/issues/:groupId/. This unmountedSharedGroupDetails(and its localOrganizationContext) before the target route had an authenticated org context loaded. Because org API calls returned 401s for unauthenticated users, child components in the issue details view calleduseOrganization()without{allowNull: true}, which threwError: useOrganization called but organization is not set.Fix
Replace the React Router
<Link>with a standard anchor tag (<a href={group.permalink}>) so clicking "Details" performs a full page reload instead of an in-app transition. This allows the application to cleanly bootstrap authentication and organization context: authenticated members load their org context properly, while unauthenticated users are directed to the login page as expected.Verification
pnpm run lint:js static/app/views/sharedGroupDetails/index.tsx(passes, 0 errors/warnings)pnpm run test static/app/views/sharedGroupDetails/index.spec.tsx(all tests pass)Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-3FSD
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.