Repository navigation
Conversation
jaydgoss
added this pull request to stack #126374
October 2, 2026 19:59
github-actions
Bot
added
the
Scope: Frontend
Delete the legacy IssueAlertOptions, IssueAlertNotificationOptions and MessagingIntegrationAlertRule components and the PlatformPicker, which only the removed CreateProject flow rendered, along with the unused growth.platformpicker_category event and filterAliases. Move the MessagingIntegrationAlertRule component tests to ScmMessagingIntegrationAlertRule, which renders the same controls through the shared useMessagingIntegrationAlertRule hook. Refs VDY-235
jaydgoss
force-pushed
the
jaygoss/remove-legacy-create-project-leftovers
branch
from
October 2, 2026 20:32
6c6890d to
21093c2
Compare
Contributor
Sentry Snapshot Testing
|
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes code that only the legacy create-project flow rendered: the
IssueAlertOptions,IssueAlertNotificationOptionsandMessagingIntegrationAlertRulecomponents,PlatformPicker, thegrowth.platformpicker_categoryevent it alone sent, and the unusedfilterAliases. The shared hooks, helpers and types these files export to the SCM flow stay.The
MessagingIntegrationAlertRulecomponent tests exercised the shareduseMessagingIntegrationAlertRulehook (channel loading, custom channels, validation errors), so they move toscmMessagingIntegrationAlertRule.spec.tsxand now renderScmMessagingIntegrationAlertRule, which uses the same hook and controls. The'legacy'analytics variant is untouched; it is still sent from other surfaces such as the framework suggestion modal and getting-started docs.Refs VDY-235.