ref(tornado): Drop send_default_pii support - #7705
pabloDeputter wants to merge 2 commits into
Conversation
send_default_pii support
Codecov Results 📊✅ 62846 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65737 | Pass Rate: 95.6% | Execution Time: 178m 19s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
sentrivana
left a comment
There was a problem hiding this comment.
LGTM, one optional improvement suggestion
| [ | ||
| pytest.param( | ||
| {"send_default_pii": True}, | ||
| {"data_collection": {}}, |
There was a problem hiding this comment.
Totally optional, but we could clean this up more now that it's not really init_kwargs anymore, but just the data_collection definition: you can remove the outer {"data_collection": } dict from the first param everywhere, and rename the param init_kwargs -> data_collection, and then just provide it in the sentry_init as data_collection=data_collection.
Description
TornadoRequestExtractorinherits fromRequestExtractorwhich still has somesend_default_piibranching, but this will be fixed in Remove send_default_pii from wsgi #7616.Issues
Resolves #7615