Skip to content

ref(tornado): Drop send_default_pii support - #7705

Open
pabloDeputter wants to merge 2 commits into
major/3.0from
pablo/tornado-drop-pii
Open

pabloDeputter wants to merge 2 commits into
major/3.0from
pablo/tornado-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Issues

Resolves #7615

@pabloDeputter pabloDeputter changed the title Pablo/tornado drop pii ref(tornado): Drop send_default_pii support Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

62846 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65737 | Pass Rate: 95.6% | Execution Time: 178m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -71317
Passed Tests 📉 -67056
Failed Tests 📈 +1
Skipped Tests 📉 -4262

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139976229253568

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139976229253568

✅ Patch coverage is 100.00%. Project has 2072 uncovered lines.
❌ Project coverage is 90.12%. Comparing base (58ea973) to head (ce25a48).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.12%    -0.08%
==========================================
  Files          194       178       -16
  Lines        26030     20982     -5048
  Branches      9678      7558     -2120
==========================================
+ Hits         23480     18910     -4570
- Misses        2550      2072      -478
- Partials      1454      1196      -258

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 24, 2026 14:15
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 24, 2026 14:15

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional improvement suggestion

[
pytest.param(
{"send_default_pii": True},
{"data_collection": {}},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally optional, but we could clean this up more now that it's not really init_kwargs anymore, but just the data_collection definition: you can remove the outer {"data_collection": } dict from the first param everywhere, and rename the param init_kwargs -> data_collection, and then just provide it in the sentry_init as data_collection=data_collection.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants