ref(sanic): Drop send_default_pii support - #7703
Open
pabloDeputter wants to merge 4 commits into
Open
pabloDeputter wants to merge 4 commits into
pabloDeputter wants to merge 4 commits into
Conversation
Contributor
Codecov Results 📊✅ 62819 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65710 | Pass Rate: 95.6% | Execution Time: 174m 14s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
pabloDeputter
marked this pull request as ready for review
September 24, 2026 14:16
sentrivana
approved these changes
Sep 24, 2026
| {"send_default_pii": False}, | ||
| None, | ||
| id="send_default_pii_false", | ||
| {"data_collection": {"url_query_params": {"mode": "denylist", "terms": []}}}, |
Contributor
There was a problem hiding this comment.
Same optional suggestion as #7705 (comment) -- we don't need the outer data_collection level since it's the same everywhere
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SanicRequestExtractorinherits fromRequestExtractorwhich still has somesend_default_piibranching, but this will be fixed in Remove send_default_pii from wsgi #7616.Issues
Resolves #7611