feat(boto3): Add common OTel AWS client attributes - #7481
Open
pabloDeputter wants to merge 1 commit into
Open
pabloDeputter wants to merge 1 commit into
pabloDeputter wants to merge 1 commit into
Conversation
Contributor
Codecov Results 📊✅ 128609 passed | ⏭️ 7151 skipped | Total: 135760 | Pass Rate: 94.73% | Execution Time: 435m 52s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 88.24%. Project has 2534 uncovered lines. Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
+ Coverage 90.18% 90.24% +0.06%
==========================================
Files 193 196 +3
Lines 25773 25960 +187
Branches 9532 9578 +46
==========================================
+ Hits 23241 23426 +185
- Misses 2532 2534 +2
- Partials 1431 1439 +8Generated by Codecov Action |
pabloDeputter
changed the title
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
pabloDeputter
marked this pull request as ready for review
September 14, 2026 09:26
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
pabloDeputter
added this pull request to stack #7500
September 14, 2026 12:53
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
from
September 14, 2026 14:42
9fe9acf to
4e8f427
Compare
| except BaseException as exc: | ||
| if span is not None: | ||
| with capture_internal_exceptions(): | ||
| _finish_active_http_child_span(span) |
Contributor
There was a problem hiding this comment.
Why are we ending the stdlib span here?
Member
Author
There was a problem hiding this comment.
We finish the HTTP span before the parent boto3 span so that the correct order is preserved. Otherwise the HTTP span would be kept active until the whole response is read, while the parent boto3 span finishes first; afterwards when the HTTP span finishes, it will restore the already-finished parent as current, causing subsequent calls to be parented incorrectly.
Member
Author
There was a problem hiding this comment.
I can send a screenshot from sentry maybe to show against latest release
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
from
September 15, 2026 12:58
aa1d65a to
939a3f8
Compare
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
2 times, most recently
from
September 17, 2026 15:50
ddf5deb to
351e3b6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit afcb977. Configure here.
pabloDeputter
changed the title
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
from
September 18, 2026 14:30
f98d2f2 to
77468b1
Compare
pabloDeputter
changed the title
pabloDeputter
removed this pull request from stack #7500
September 18, 2026 14:34
pabloDeputter
changed the base branch from
master
to
pablo/trace-boto3-client-call-lifecycle
September 18, 2026 14:34
pabloDeputter
added this pull request to stack #7539
September 18, 2026 14:35
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
from
September 18, 2026 15:06
77468b1 to
6ea0078
Compare
pabloDeputter
removed this pull request from stack #7539
September 18, 2026 15:08
pabloDeputter
added this pull request to stack #7541
September 18, 2026 15:08
pabloDeputter
force-pushed
the
pablo/improve-boto3-call-lifecycle
branch
from
September 18, 2026 15:20
6ea0078 to
0d61ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #7475 by adding common OTel attributes to boto client spans.
Changes
rpc.system.name,rpc.service,rpc.method,cloud.region,server.address,server.port.rpc.system.nametoaws-apiService.Operation(now it'saws.<service>.<Operation>), e.g.S3.HeadObjectfollowing OTel is a breaking change and will be done in major.rpc.service; not supported anymore by OTel, but JS keeps this too.rpc.method.AwsCallContextto carry extra client metadata for instrumentation.Issues
Resolves #7475