Skip to content

Commit 9fe9acf

Browse files
committed
restore span name/description to aws.<service-hyphenized>.<Operation>, e.g. aws.s3.GetObject
1 parent a61d088 commit 9fe9acf

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎sentry_sdk/integrations/boto3/_instrumentation.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@ def _start_client_span(
9292
if client.get_integration(Boto3Integration) is None:
9393
return None
9494

95-
# OTel define `rpc.service` as `Service.Operation`, e.g. `DynamoDB.GetItem`.
96-
# https://opentelemetry.io/docs/specs/semconv/cloud-providers/aws-sdk/#aws-sdk-spans
97-
span_name = "%s.%s" % (ctx.service_id, ctx.operation_name)
95+
span_name = "aws.%s.%s" % (ctx.service_id_hyphenized, ctx.operation_name)
9896
attributes = _get_client_attributes(ctx)
9997
span_op = OP.HTTP_CLIENT
10098
span_origin = Boto3Integration.origin

‎tests/integrations/boto3/test_client.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def _span_attributes(span, span_streaming):
153153
"s3",
154154
"head_object",
155155
{"Bucket": "bucket", "Key": "foo"},
156-
"S3.HeadObject",
156+
"aws.s3.HeadObject",
157157
"S3",
158158
"HeadObject",
159159
"http://localhost:4566",
@@ -164,7 +164,7 @@ def _span_attributes(span, span_streaming):
164164
"events",
165165
"list_event_buses",
166166
{},
167-
"EventBridge.ListEventBuses",
167+
"aws.eventbridge.ListEventBuses",
168168
"EventBridge",
169169
"ListEventBuses",
170170
None,

0 commit comments

Comments
 (0)