-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(nuxt): Stop importing h3 in the Nitro error hook #24283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bba689c
fix(nuxt): Split the Nitro error hook as Nuxt 5 stops importing h3
s1gr1d c457bae
Merge branch 'develop' into t3code/9c33bc1e
s1gr1d 8c5de5e
remove h3 imports
s1gr1d de5d1b9
fix review
s1gr1d 90f5e99
add third-party-error test
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
dev-packages/e2e-tests/test-applications/nuxt-4/server/api/third-party-http-error.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { defineEventHandler } from '#imports'; | ||
|
|
||
| // Mimics ky's and got's `HTTPError`: it shares its `name` with h3's error class, but keeps the | ||
| // status on `response` instead of on the error itself. | ||
| class ThirdPartyHTTPError extends Error { | ||
| public readonly response = { status: 404 }; | ||
|
|
||
| public constructor(message: string) { | ||
| super(message); | ||
| this.name = 'HTTPError'; | ||
| } | ||
| } | ||
|
|
||
| export default defineEventHandler(() => { | ||
| throw new ThirdPartyHTTPError('Nuxt 4 third-party HTTPError'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
dev-packages/e2e-tests/test-applications/nuxt-5/server/api/third-party-http-error.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { defineHandler } from 'nitro'; | ||
|
|
||
| // Mimics ky's and got's `HTTPError`: it shares its `name` with h3's error class, but keeps the | ||
| // status on `response` instead of on the error itself. | ||
| class ThirdPartyHTTPError extends Error { | ||
| public readonly response = { status: 404 }; | ||
|
|
||
| public constructor(message: string) { | ||
| super(message); | ||
| this.name = 'HTTPError'; | ||
| } | ||
| } | ||
|
|
||
| export default defineHandler(() => { | ||
| throw new ThirdPartyHTTPError('Nuxt 5 third-party HTTPError'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.