fix(nuxt): Stop importing h3 in the Nitro error hook - #24283
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
This still fails, but because of another issue. That's probably an upstream issue. Created a PR to add |
s1gr1d
added a commit
that referenced
this pull request
Sep 10, 2026
Related to this comment: #24283 (comment)
s1gr1d
marked this pull request as ready for review
September 10, 2026 13:56
s1gr1d
requested review from
mydea and
nicohrubec
and removed request for
a team
September 10, 2026 13:56
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
approved these changes
Sep 14, 2026
| */ | ||
| export default (nitroApp => { | ||
| // @ts-expect-error Nitro v3 hands the `error` hook an `HTTPEvent`, Nitro v2 an `H3Event` | ||
| nitroApp.hooks.hook('error', sentryCaptureErrorHook); |
Member
There was a problem hiding this comment.
l/q: Can't we do a function overload then?
Member
Author
There was a problem hiding this comment.
This is also connected to the differences of nitro and nitropack but I can rework the function so there's no h3 import needed. And then we also don't need the expect-error.
| @@ -0,0 +1,12 @@ | |||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
| import { H3Error } from 'h3'; | |||
Member
There was a problem hiding this comment.
q: Why can't we simply move it to nitro/h3 entirely? Then we could keep everything in one function
Member
Author
There was a problem hiding this comment.
No, this does not work on Nuxt 3 and 4 because they don't ship nitro but nitropack. That's why we need different files and a proxy.
s1gr1d
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuxt 5 switched on its Nitro v2 compatibility layer for any module whose server code imports
h3: nuxt/nuxt#36318The hook now recognizes h3 errors the way h3 itself does, without importing it: h3 v2 by the error's
name, h3 v1 by the static__h3_error__flag on the class. Both exposestatusCode.Our CI tests currently show this warning: