Skip to content

ref: Remove redundant forceTransaction: true usages #23756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Aug 31, 2026
Merged

ref: Remove redundant forceTransaction: true usages #23756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/aws-serverless/src/requestSpanOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export function getRequestSpanOptions(event: unknown, context: Context, requestI
// The span is started within the surrounding `continueTrace`, so it continues the incoming trace.
return {
name: context.functionName,
forceTransaction: true,
attributes: {
[SENTRY_OP]: FUNCTION_AWS,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.aws_lambda',
Expand Down
1 change: 0 additions & 1 deletion packages/browser/src/tracing/browserTracingIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,6 @@ export const browserTracingIntegration = ((options: Partial<BrowserTracingOption
...startSpanOptions,
// Navigation starts a new trace and is NOT parented under any active interaction (e.g. ui.action.click)
parentSpan: null,
forceTransaction: true,
},
true,
navigationOptions?.url,
Expand Down
2 changes: 0 additions & 2 deletions packages/nestjs/src/integrations/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ const PROCESS_OPERATION = 'process';
export function getBullMQProcessSpanOptions(queueName: string | undefined): {
name: string;
attributes: Record<string, string | undefined>;
forceTransaction: boolean;
} {
const client = getClient();
const isStreamed = !!client && hasSpanStreamingEnabled(client);
Expand All @@ -151,7 +150,6 @@ export function getBullMQProcessSpanOptions(queueName: string | undefined): {
[MESSAGING_OPERATION_TYPE]: PROCESS_OPERATION,
[MESSAGING_DESTINATION_NAME]: queueName,
},
forceTransaction: true,
};
}

Expand Down
1 change: 0 additions & 1 deletion packages/react-router/src/server/createServerInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export function createSentryServerInstrumentation(
await startSpan(
{
name: unparameterizedName,
forceTransaction: true,
attributes: {
[SENTRY_OP]: HTTP_SERVER,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.react_router.instrumentation_api',
Expand Down
3 changes: 1 addition & 2 deletions packages/react-router/test/server/createServerInstrumentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,10 @@ describe('createSentryServerInstrumentation', () => {

await hooks.request(mockHandleRequest, { request: mockRequest, context: undefined });

// Should create a new root span with forceTransaction
// Should create a new root span
expect(core.startSpan).toHaveBeenCalledWith(
expect.objectContaining({
name: 'GET /api/users',
forceTransaction: true,
attributes: expect.objectContaining({
'sentry.op': 'http.server',
'sentry.origin': 'auto.http.react_router.instrumentation_api',
Expand Down
Loading