ref: Remove redundant forceTransaction: true usages - #23756
Merged
Merged
Conversation
andreiborza
force-pushed
the
ab/investigate-remove-force-transaction
branch
from
August 31, 2026 09:03
0e14ea4 to
8bfd701
Compare
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/investigate-remove-force-transaction
branch
from
August 31, 2026 09:45
8bfd701 to
564cc92
Compare
andreiborza
changed the title
forceTransaction: true usagesforceTransaction: true usages
Removes `forceTransaction: true` where the span is already a root span, so the option had no effect: - `aws-serverless`: the `function.aws` invocation span - `browser`: the navigation span, which already passes `parentSpan: null` - `nestjs`: the BullMQ process span, since queue jobs run outside a request - `react-router`: the server request span, on the branch that only runs when there is no root span Co-Authored-By: Opus 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/investigate-remove-force-transaction
branch
from
August 31, 2026 09:46
564cc92 to
c665424
Compare
andreiborza
marked this pull request as ready for review
August 31, 2026 11:26
andreiborza
requested review from
isaacs,
msonnb,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
August 31, 2026 11:26
mydea
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
forceTransaction: truefrom four spans that are already root spans, so the option had no effect.aws-serverless: thefunction.awsinvocation spanbrowser: the navigation span, which already passesparentSpan: nullnestjs: the BullMQ process span, since queue jobs run outside a requestreact-router: the server request span, on the branch that only runs when there is no root spanThe remaining usages are:
POST /messagesand/ GET /sse, and themcp.servertransaction that the Insights views read is gone.withServerActionInstrumentationforks an isolation scope and sets the transaction name, theextradata and the request headers on it. With no transaction in that scope, all of it is dropped.sentry.parent_span_already_sent, but only because the handler outlives the request. A synchronous handler would nest instead.Why
Less to read, and the flag now marks only the spans that truly need it.