test(e2e): Add Next.js standalone output test app - #23679
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
reviewed
Aug 27, 2026
Comment on lines
+49
to
+53
| { | ||
| "build-command": "pnpm test:build", | ||
| "label": "nextjs-16-standalone (turbopack)", | ||
| "assert-command": "pnpm test:assert" | ||
| } |
Member
There was a problem hiding this comment.
isn't that the default variant anyway
Comment on lines
+49
to
+53
| { | ||
| "build-command": "pnpm test:build", | ||
| "label": "nextjs-16-standalone (turbopack)", | ||
| "assert-command": "pnpm test:assert" | ||
| } |
Member
There was a problem hiding this comment.
can you add a canary version ?
chargome
approved these changes
Aug 31, 2026
JPeer264
approved these changes
Aug 31, 2026
andreiborza
disabled the stack merge
August 31, 2026 15:08
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/e2e-nextjs-16-standalone
branch
from
September 1, 2026 11:42
34c5ec7 to
b7c4e61
Compare
andreiborza
added a commit
that referenced
this pull request
Sep 2, 2026
…th so build tracers follow it (#23687) Stacked on #23679. ## What `register.ts` (now in `@sentry/server-runtime-injection`) resolves the orchestrion ESM loader hook from its own on-disk location instead of through the `@sentry/server-runtime-injection/hook` self-reference, and the standalone e2e app asserts the hook reaches the traced output. It keeps the self-reference as a fallback for a bundled copy, where the relative path points at nothing. Fixes [JS-3451](https://linear.app/getsentry/issue/JS-3451). ## Why `Module.register()` resolves its specifier at runtime. `@vercel/nft` does evaluate those calls, but not through the interop namespace helper rollup emits in the CJS build, which is the build Next.js loads, so the hook never reached traced output. `output: 'standalone'`, Docker and Vercel deploys then lost channel-based instrumentation entirely, and only said so behind `debug: true`. The new path is a literal that both builds expose to tracers, computed at runtime so nothing absolute is baked in. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
nextjs-16-standalonee2e app, the only one in the repo that builds withoutput: 'standalone'. It asserts the relocated server output carries no absolute-path imports, and covers the standalone server serving requests and reporting errors.Why
Nothing on
developexercisedoutput: 'standalone', so the nft trace, the file copy andnode .next/standalone/server.jswent untested. That is the deploy shape where a build-time path baked into a chunk actually breaks, as #23266 showed.