fix(server-runtime-injection): Resolve the orchestrion ESM hook by path so build tracers follow it - #23687
Merged
andreiborza merged 2 commits intoSep 2, 2026
Conversation
Contributor
size-limit report 📦
|
Member
|
not sure but this could conflict/overlap with #23685? |
Member
Author
|
@mydea yea, I'll wait until yours lands. |
andreiborza
force-pushed
the
ab/fix-standalone-orchestrion-hook-tracing
branch
from
September 1, 2026 11:42
badd3e7 to
09caa8b
Compare
andreiborza
changed the title
andreiborza
force-pushed
the
ab/fix-standalone-orchestrion-hook-tracing
branch
from
September 1, 2026 11:50
09caa8b to
e4cd548
Compare
andreiborza
force-pushed
the
ab/fix-standalone-orchestrion-hook-tracing
branch
from
September 1, 2026 12:28
e4cd548 to
8bfd325
Compare
…th so build tracers follow it Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/fix-standalone-orchestrion-hook-tracing
branch
from
September 1, 2026 12:33
8bfd325 to
f91a830
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f91a830. Configure here.
andreiborza
marked this pull request as ready for review
September 1, 2026 13:01
andreiborza
requested review from
a team,
chargome,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
nicohrubec
September 1, 2026 13:01
mydea
approved these changes
Sep 2, 2026
Member
|
Seems fine to me! Maybe a test actually running nft would be nice? |
Member
Author
|
Added `test/nftTrace.test.ts`, which runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23679.
What
register.ts(now in@sentry/server-runtime-injection) resolves the orchestrion ESM loader hook from its own on-disk location instead of through the@sentry/server-runtime-injection/hookself-reference, and the standalone e2e app asserts the hook reaches the traced output. It keeps the self-reference as a fallback for a bundled copy, where the relative path points at nothing.Fixes JS-3451.
Why
Module.register()resolves its specifier at runtime.@vercel/nftdoes evaluate those calls, but not through the interop namespace helper rollup emits in the CJS build, which is the build Next.js loads, so the hook never reached traced output.output: 'standalone', Docker and Vercel deploys then lost channel-based instrumentation entirely, and only said so behinddebug: true. The new path is a literal that both builds expose to tracers, computed at runtime so nothing absolute is baked in.