fix(core): [Data Collection 24] Narrow utility exception handling - #6065
Draft
adinauer wants to merge 1 commit into
Draft
fix(core): [Data Collection 24] Narrow utility exception handling#6065adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Catch only the recoverable failures produced while filtering GraphQL bodies and decoding query parameter names. Preserve fail-closed handling for malformed GraphQL Unicode escapes without swallowing fatal JVM errors. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Sep 7, 2026
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Data Collection)
📜 Description
Narrow the exception handlers used while filtering GraphQL request bodies and decoding query parameter names. Keep malformed GraphQL Unicode escapes fail-closed by catching the vendored JSON reader's documented
NumberFormatExceptionalongsideIOException.💡 Motivation and Context
The previous
catch (Throwable)blocks could swallow fatal JVM errors such asOutOfMemoryErrorandThreadDeath. These handlers now catch only the recoverable failures produced by their parsing operations while preserving the existing fallback behavior for malformed input.Refs #5666
💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.util.GraphqlUtilsTest --tests io.sentry.util.HttpUtilsTest --rerun-tasks./gradlew spotlessApply apiDumpgit diff --check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
#skip-changelog