Skip to content

Enforce explicit actor-target checks for profile/password updates #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giuscris merged 1 commit into from
Jun 27, 2026
Merged

Enforce explicit actor-target checks for profile/password updates #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions formwork/src/Users/User.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,34 +191,31 @@ public function isAdmin(): bool
*/
public function canDeleteUser(User $user): bool
{
return $this->isAdmin() && !$user->isLoggedIn();
return $this->isAdmin() && $this->username() !== $user->username();
}
Comment thread
giuscris marked this conversation as resolved.

/**
* Return whether the user can change options of a given user
*/
public function canChangeOptionsOf(User $user): bool
{
if ($this->isAdmin()) {
return true;
}
return $user->isLoggedIn();
return $this->isAdmin() || $this->username() === $user->username();
}

/**
* Return whether the user can change the password of a given user
*/
public function canChangePasswordOf(User $user): bool
{
return $user->isLoggedIn();
return $this->username() === $user->username();
}

/**
* Return whether the user can change the role of a given user
*/
public function canChangeRoleOf(User $user): bool
{
return $this->isAdmin() && !$user->isLoggedIn();
return $this->isAdmin() && $this->username() !== $user->username();
}

/**
Expand Down
Loading