Enforce explicit actor-target checks for profile/password updates#910
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens permission checks in Formwork\Users\User by switching from session-derived “logged in” checks to explicit actor-vs-target comparisons, ensuring sensitive actions are only allowed for the correct user (or admins, where applicable).
Changes:
- Updated delete/role-change permissions to allow admins to act only on other users (not themselves).
- Updated options/password permissions to allow only self-service changes (with admins allowed to edit any user’s options).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates user permission logic in the
Userclass to improve security and ensure users can only perform sensitive actions on their own accounts or, for admins, on other users. The changes focus on refining checks for deleting users, changing options, passwords, and roles.Permission logic updates:
canDeleteUserandcanChangeRoleOfto allow admins to act only on other users, not themselves.canChangeOptionsOfandcanChangePasswordOfto allow users to modify only their own options or password, unless they are admins (who can modify any user’s options).