Repository navigation
Fix dead click areas on task embed cards - #5903
Merged
ymichael merged 4 commits intoOct 20, 2026
Merged
Conversation
…-docs-embed-cards-thr_nzf9kqerem
#5640 added @bb/query-tags with a typescript-7 (npm:typescript@^7.0.2) dev dependency. #5861 merged first and removed typescript@7.0.2 from the lockfile when it moved every package to tsrs. The merged lockfile kept the importer entry without a package entry, so pnpm install --frozen-lockfile fails with ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY. Move query-tags to tsrs like every other package.
ymichael
deleted the
bb/fix-dead-clicks-on-docs-embed-cards-thr_nzf9kqerem
branch
October 20, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Task embed cards applied a hover background to their wrapper, but the primary button covered only the content. Clicking the side padding, vertical padding, or gap before the open arrow did nothing. Loading cards also highlighted despite having no action. This is the same hit-area mismatch addressed for other rows in #5891.
What changed
Stretch the primary button over the rounded card and keep the open-in-Tasks arrow above it as a separate control. Show a focus ring around the whole primary target, prevent repeated clicks from selecting text, and apply hover styling only to resolved, actionable cards.
To unblock CI against current main, this branch also carries the existing query-tags lockfile repair from #5897 (switch its typecheck to the repository's pinned tsrs) and bumps the plugin SDK to 0.6.61 because the npm version guard detects changed generated declarations in 0.6.60. Neither changes the task-card interaction contract.
How you verified
pnpm start:worktree, seeded a disposable task and embed message, and confirmed a real padding click opens the task in the production app.pnpm exec turbo run typecheck lint test --filter=bb-plugin-taskspassed, including all 409 tests.git diff --checkpassed. No new jsdom regression test: it cannot exercise layout or pointer hit testing.