Repository navigation
Typecheck query-tags with tsrs to fix the broken lockfile on main - #5897
Closed
ahmedhesham6 wants to merge 2 commits into
Closed
ahmedhesham6 wants to merge 2 commits into
ahmedhesham6 wants to merge 2 commits into
Conversation
get-bb#5640 added @bb/query-tags with a typescript-7 (npm:typescript@^7.0.2) dev dependency. get-bb#5861 merged first and removed typescript@7.0.2 from the lockfile when it moved every package to tsrs. The merged lockfile kept the importer entry without a package entry, so pnpm install --frozen-lockfile fails with ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY. Move query-tags to tsrs like every other package.
get-bb#5640 changed the realtime change-message schema in the plugin SDK bundled types after 0.6.60 was published, so the npm version guard fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymichael
added a commit
that referenced
this pull request
Oct 20, 2026
## Human comments ## What was wrong Task embed cards applied a hover background to their wrapper, but the primary button covered only the content. Clicking the side padding, vertical padding, or gap before the open arrow did nothing. Loading cards also highlighted despite having no action. This is the same hit-area mismatch addressed for other rows in #5891. ## What changed Stretch the primary button over the rounded card and keep the open-in-Tasks arrow above it as a separate control. Show a focus ring around the whole primary target, prevent repeated clicks from selecting text, and apply hover styling only to resolved, actionable cards. To unblock CI against current main, this branch also carries the existing query-tags lockfile repair from #5897 (switch its typecheck to the repository's pinned tsrs) and bumps the plugin SDK to 0.6.61 because the npm version guard detects changed generated declarations in 0.6.60. Neither changes the task-card interaction contract. ## How you verified - Reproduced the dead padding and gap with real browser pointer clicks before the fix, using the actual component and production styles in an isolated fixture. - Verified the same coordinates open the side panel after the fix, while the arrow only opens Tasks. Also checked keyboard Enter/Space, the full-card focus ring, rounded corners, fallback navigation, retry, the missing-task arrow, and loading without hover feedback. - Started this branch with `pnpm start:worktree`, seeded a disposable task and embed message, and confirmed a real padding click opens the task in the production app. - `pnpm exec turbo run typecheck lint test --filter=bb-plugin-tasks` passed, including all 409 tests. - Formatting and `git diff --check` passed. No new jsdom regression test: it cannot exercise layout or pointer hit testing. > AGENT GENERATED --------- Co-authored-by: Ahmed Hesham Abdelkader <23265119+ahmedhesham6@users.noreply.github.com>
Collaborator
|
Superseded: #5903 landed the same query-tags tsrs switch and the plugin SDK 0.6.61 bump on main, so this PR's diff against main is now empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
CI on main fails at dependency install since 8a85f5b (#5640):
#5640 added a new package,
@bb/query-tags, with the dev dependency"typescript-7": "npm:typescript@^7.0.2"and"typecheck": "tsc --noEmit". #5861 (75b90b9) merged first. It moved every package fromtypescript-7totsrs, so pnpm removed thetypescript@7.0.2package and snapshot entries from the lockfile. When #5640 merged, the lockfile kept itspackages/query-tagsimporter entry (typescript-7: typescript@7.0.2), but no package entry remained for it.@bb/query-tagsis the only manifest that still liststypescript-7.What changed
packages/query-tags/package.json: replacetypescript-7withtsrspinned to0.18.0-ts7.1.0-dev.20260929, and runtypecheckwithtsrs --noEmit. This is the same change Typecheck with tsrs instead of TypeScript 7 tsc #5861 made to every other package.pnpm-lock.yaml: update thepackages/query-tagsimporter to match (3 lines added, 3 removed).tsrswas already locked, so the change adds no new packages.@get-bb/plugin-sdk0.6.60 → 0.6.61. Declare live-data tags on route contracts and refresh through tagged mutations #5640 also changed the realtime change-message schema in the SDK's bundled types (droppedui-preferences-changed, added{type:"changed", entity:"tags"}) after 0.6.60 was published, so once install worked theCheck plugin SDK npm version guardstep failed. Bumped withnode scripts/bump-plugin-sdk.mjs --patch; the guard passes locally.I did not put the
typescript@7.0.2entries back in the lockfile, because #5861 removed TypeScript 7 on purpose.How you verified
On origin/main (8a85f5b):
On this branch:
Bug hunt: no external call or stored state. The diff changes only a dev-tool manifest and its lockfile entry.
Not verified