Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/agent-runtime/src/claude-code/adapter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5632,4 +5632,24 @@ describe("claude-code provider adapter", () => {
const events = adapter.translateEvent(loadFixture("system-init.json"));
expect(events).toMatchObject([]);
});

it("ignores Claude command lifecycle events", () => {
const adapter = createClaudeCodeProviderAdapter();
const events = adapter.translateEvent({
jsonrpc: "2.0",
method: "sdk/message",
params: {
threadId: "thread-1",
message: {
type: "command_lifecycle",
command_uuid: "command-1",
state: "started",
uuid: "message-1",
session_id: "session-1",
},
},
});

expect(events).toEqual([]);
});
});
13 changes: 13 additions & 0 deletions packages/agent-runtime/src/claude-code/visibility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ interface ClaudeUnknownSdkRawEvent {
sdkType?: string;
}

interface ClaudeCommandLifecycleRawEvent {
kind: "sdk/command_lifecycle";
}

interface ClaudeAssistantRawEvent {
contentTypes: ClaudeMessageContentType[];
kind: "sdk/assistant";
Expand Down Expand Up @@ -151,6 +155,7 @@ interface ClaudeSimpleStreamRawEvent {

type ClaudeRawEvent =
| ClaudeAssistantRawEvent
| ClaudeCommandLifecycleRawEvent
| ClaudeErrorRawEvent
| ClaudeNonSdkRawEvent
| ClaudeRateLimitRawEvent
Expand Down Expand Up @@ -298,6 +303,9 @@ function parseClaudeRawEvent(event: JsonRpcMessage): ClaudeRawEvent {
),
};

case "command_lifecycle":
return { kind: "sdk/command_lifecycle" };

case "rate_limit_event":
return { kind: "sdk/rate_limit_event" };

Expand Down Expand Up @@ -423,6 +431,11 @@ function describeParsedClaudeRawEvent(
return { kind, coverage: "unknown" };
}

// Internal command queue telemetry used by remote Claude surfaces for
// lifecycle acknowledgements. It has no transcript or turn semantics.
case "sdk/command_lifecycle":
return { kind: "sdk/command_lifecycle", coverage: "noise" };

case "sdk/user": {
const kind = toClaudeMessageKind("sdk/user", event.contentTypes);
if (kind === "sdk/user:text") {
Expand Down
22 changes: 22 additions & 0 deletions packages/agent-runtime/src/provider-visibility.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,28 @@ describe("provider visibility raw events", () => {
});
});

it("classifies Claude command lifecycle events as noise", () => {
expect(
claudeCodeVisibilityMetadata.describeRawEvent({
jsonrpc: "2.0",
method: "sdk/message",
params: {
threadId: "thread-1",
message: {
type: "command_lifecycle",
command_uuid: "command-1",
state: "started",
uuid: "message-1",
session_id: "session-1",
},
},
} satisfies JsonRpcMessage),
).toEqual({
kind: "sdk/command_lifecycle",
coverage: "noise",
});
});

it("classifies Claude thinking token system events as noise", () => {
expect(
claudeCodeVisibilityMetadata.describeRawEvent({
Expand Down
Loading