Skip to content

Suppress Claude command lifecycle debug events - #1332

Merged
ymichael merged 1 commit into
mainfrom
bb/thr_b6ajdhnrh9
Aug 11, 2026
Merged

Suppress Claude command lifecycle debug events#1332
ymichael merged 1 commit into
mainfrom
bb/thr_b6ajdhnrh9

Conversation

@ymichael

Copy link
Copy Markdown
Collaborator

Summary

  • recognize Claude command_lifecycle SDK telemetry explicitly
  • classify the internal lifecycle acknowledgement as noise instead of persisting provider/unhandled rows
  • cover both raw visibility classification and adapter translation

Test plan

  • pnpm exec turbo run typecheck --filter=@bb/agent-runtime
  • pnpm exec turbo run test --filter=@bb/agent-runtime --force -- --run src/provider-visibility.test.ts src/claude-code/adapter.test.ts (151 passed)

Additional validation

The full agent-runtime suite reached 877 passing tests. The unrelated runtime.process-lifecycle stderr-tail assertion failed and reproduced when run in isolation.

@SawyerHood

Copy link
Copy Markdown
Collaborator

🚨 SLOP COP 🚨 · review

I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and end-to-end behavior.

@ymichael
ymichael merged commit d07c1ce into main Aug 11, 2026
10 checks passed
@ymichael
ymichael deleted the bb/thr_b6ajdhnrh9 branch August 11, 2026 17:11

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

ELI5: Claude sends small notes that say a command started or finished. This change hides those notes, like removing ticket stubs from a chat.

I found no blocking or non-blocking issues.

  • Security: The change reduces raw event exposure. It does not change a trust boundary.
  • Code quality: The new event uses the existing Claude visibility parser and shared suppression gate.
  • Architecture: The project has no duplicate command_lifecycle classifier. A new shared abstraction would add more code than value.
  • Performance: The two switch cases take constant time. They also prevent event allocation and storage.
  • Tests: The 151 focused tests passed. The @bb/agent-runtime type-check passed.
  • Full suite: 892 of 893 local package tests passed. One macOS process test outside this change failed. All GitHub checks passed.
  • Browser smoke test: The exact commit started successfully. The app and API returned HTTP 200. The bb home page loaded in Chromium.

A direct browser reproduction needs Claude to emit this internal lifecycle event. The adapter and visibility tests cover that event path directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants