Suppress Claude command lifecycle debug events - #1332
Merged
Conversation
Collaborator
|
🚨 SLOP COP 🚨 · I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and end-to-end behavior. |
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
left a comment
Collaborator
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: Claude sends small notes that say a command started or finished. This change hides those notes, like removing ticket stubs from a chat.
I found no blocking or non-blocking issues.
- Security: The change reduces raw event exposure. It does not change a trust boundary.
- Code quality: The new event uses the existing Claude visibility parser and shared suppression gate.
- Architecture: The project has no duplicate
command_lifecycleclassifier. A new shared abstraction would add more code than value. - Performance: The two switch cases take constant time. They also prevent event allocation and storage.
- Tests: The 151 focused tests passed. The
@bb/agent-runtimetype-check passed. - Full suite: 892 of 893 local package tests passed. One macOS process test outside this change failed. All GitHub checks passed.
- Browser smoke test: The exact commit started successfully. The app and API returned HTTP 200. The bb home page loaded in Chromium.
A direct browser reproduction needs Claude to emit this internal lifecycle event. The adapter and visibility tests cover that event path directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command_lifecycleSDK telemetry explicitlyprovider/unhandledrowsTest plan
pnpm exec turbo run typecheck --filter=@bb/agent-runtimepnpm exec turbo run test --filter=@bb/agent-runtime --force -- --run src/provider-visibility.test.ts src/claude-code/adapter.test.ts(151 passed)Additional validation
The full agent-runtime suite reached 877 passing tests. The unrelated
runtime.process-lifecyclestderr-tail assertion failed and reproduced when run in isolation.