Skip to content

[repo-assist] Treat missing dependencies as no dependencies (with test) - #4373

Merged
dsyme merged 2 commits into
masterfrom
repo-assist/artifactory-empty-deps-with-test-8f2fdb3ca0a6f39e
Aug 27, 2026
Merged

[repo-assist] Treat missing dependencies as no dependencies (with test)#4373
dsyme merged 2 commits into
masterfrom
repo-assist/artifactory-empty-deps-with-test-8f2fdb3ca0a6f39e

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

🤖 This is an automated response from Repo Assist.

This PR replicates the changes from #4321 (which is from a fork and couldn't be updated directly) and adds the requested test, per @dsyme's request: "Please make a new PR with the same contents as this PR but adding a test."

Root cause

Some OData feeds (e.g. JFrog Artifactory) omit the <d:Dependencies> node entirely for packages that have no dependencies, instead of including it with empty content. NuGetV2.fs previously treated a missing node as an error (failwithf "unable to find dependencies for package..."), causing package resolution to fail against such feeds.

Fix

Cherry-picked from the original PR (commit d98e779ea): when the Dependencies node is absent, treat it as an empty dependency list ("") instead of throwing.

Test added

can parse package without Dependencies node as no dependencies in tests/Paket.Tests/NuGetOData/ODataSpecs.fs, using a new fixture NuGetOData/NoDependenciesNode.xml (an OData entry without the <d:Dependencies> element, modeled on the Artifactory response shape). It asserts the parsed entry has an empty SerializedDependencies list instead of throwing.

Test Status

Ran dotnet test tests/Paket.Tests/Paket.Tests.fsproj --filter "FullyQualifiedName~ODataSpecs" — all 13 tests pass on net9. The net461 target could not execute in this sandbox (Could not find 'mono' host), which is an environment limitation unrelated to this change.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
Comment /repo-assist to run again

Add this agentic workflow to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@ae8d551f07c7ed7619f8c58c7bb4c3ac89395d38

github-actions Bot and others added 2 commits August 27, 2026 15:01
@dsyme
dsyme marked this pull request as ready for review August 27, 2026 21:03
@dsyme
dsyme merged commit 867cb6d into master Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant