Skip to content

Treat missing dependencies as no dependencies - #4321

Closed
Desarc wants to merge 1 commit into
fsprojects:masterfrom
Desarc:artifactory-empty-dependencies
Closed

Treat missing dependencies as no dependencies#4321
Desarc wants to merge 1 commit into
fsprojects:masterfrom
Desarc:artifactory-empty-dependencies

Conversation

@Desarc

@Desarc Desarc commented Jan 23, 2026

Copy link
Copy Markdown

This resolves #4319.

I'm not sure how I would add a test for this, or if it can cause issues in other contexts. I have tested with both of the versions of JFrog Artifactory we are using, and a few different packages, and there were no issues. I also tested with https://api.nuget.org/v3/index.json, same result.

Please let me know if there are other cases that should be tested, if I need to add something to the test suite, or if there are other things to consider with this change.

@dsyme

dsyme commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

/repo-assist please add a test for this

@fsprojects fsprojects deleted a comment from github-actions Bot Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

✓ Repo Assist completed successfully, see workflow run.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

@dsyme

dsyme commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

/repo-assist please add a test for this

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✗ Repo Assist encountered failed to deliver outputs, see workflow run.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Warning

The push_to_pull_request_branch operation failed: Cannot push to fork PR: head repository 'Desarc/Paket' does not match target 'fsprojects/Paket'. Configure safe-outputs.push-to-pull-request-branch.head-repo and matching credentials to allow an automation-owned fork.. The code changes were not applied.

🤖 This is an automated response from Repo Assist.

I've added a unit test covering this change: can parse package without Dependencies node as no dependencies in tests/Paket.Tests/NuGetOData/ODataSpecs.fs, using a new fixture (NoDependenciesNode.xml, an OData entry without the <d:Dependencies> element, modeled on JFrog Artifactory's response shape). It asserts the parsed package has an empty dependency list instead of throwing.

Ran locally with dotnet test tests/Paket.Tests/Paket.Tests.fsproj --filter "FullyQualifiedName~ODataSpecs" — all 12 tests pass on net9 (net461 run couldn't execute due to a missing mono host in this environment, unrelated to the change).

Generated by 🌈 Repo Assist, see workflow run. Learn more.
Comment /repo-assist to run again

Add this agentic workflow to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@ae8d551f07c7ed7619f8c58c7bb4c3ac89395d38

@fsprojects fsprojects deleted a comment from github-actions Bot Aug 27, 2026
@fsprojects fsprojects deleted a comment from github-actions Bot Aug 27, 2026
@fsprojects fsprojects deleted a comment from github-actions Bot Aug 27, 2026
@dsyme

dsyme commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

/repo-assist Please make a new PR with the same contents as this PR but adding a test.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✓ Repo Assist completed successfully, see workflow run.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paket fails to resolve packages in JFrog Artifactory with no dependencies

2 participants